[manila-csi-plugin] ControllerExpandVolume: fix bad key for deleting from pendingVolumes by m-k8s · Pull Request #1667 · kubernetes/cloud-provider-openstack

m-k8s · 2021-10-12T15:27:50Z

What this PR does / why we need it:

Correctly removes the volume from pendingVolumes when the expansion is complete.

Which issue this PR fixes(if applicable):
fixes #1666

Release note:

NONE

…Volumes.Delete /closes kubernetes#1666

k8s-ci-robot · 2021-10-12T15:27:53Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-10-12T15:27:57Z

Welcome @alexisries!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-10-12T15:27:58Z

Hi @alexisries. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-10-12T15:38:12Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 7m 51s

gouthampacha · 2021-10-13T05:33:58Z

/ok-to-test

…mes.Delete

theopenlab-ci · 2021-10-13T07:51:43Z

Build failed.

cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 7m 50s

gman0 · 2021-10-13T08:07:05Z

@alexisries thank you for your contribution! The CI job is failing because it's WIP. I believe we can merge this since this is just reverting (accidental) change we've done earlier, as @gouthampacha pointed out.

/lgtm
/approve

gman0 · 2021-10-13T08:08:44Z

/override cloud-provider-openstack-acceptance-test-csi-manila
/override openstack-cloud-csi-manila-e2e-test

k8s-ci-robot · 2021-10-13T08:08:45Z

@gman0: gman0 unauthorized: /override is restricted to Repo administrators.

Details

In response to this:

/override cloud-provider-openstack-acceptance-test-csi-manila
/override openstack-cloud-csi-manila-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gman0 · 2021-10-13T08:09:37Z

@ramineni can you please help us merge this?

m-k8s · 2021-10-13T11:49:07Z

/retest-required

gman0 · 2021-10-13T11:51:11Z

@alexisries the tests need to be overriden by CPO admins.

ramineni · 2021-10-13T14:44:30Z

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

k8s-ci-robot · 2021-10-13T14:44:32Z

@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-csi-manila

Details

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ramineni · 2021-10-13T14:45:37Z

/override openstack-cloud-csi-manila-e2e-test

k8s-ci-robot · 2021-10-13T14:45:41Z

@ramineni: Overrode contexts on behalf of ramineni: openstack-cloud-csi-manila-e2e-test

Details

In response to this:

/override openstack-cloud-csi-manila-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ramineni · 2021-10-13T14:45:48Z

/approve

k8s-ci-robot · 2021-10-13T14:46:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gman0, ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/csi/manila/OWNERS~~ [gman0,ramineni]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…from pendingVolumes (kubernetes#1667) * [manila-csi-plugin] in ControllerExpandVolume fix bad key for pendingVolumes.Delete /closes kubernetes#1666 * [manila-csi-plugin] use share.Name to identify volumes in pendingVolumes.Delete

…from pendingVolumes (#1667) (#1675) * [manila-csi-plugin] in ControllerExpandVolume fix bad key for pendingVolumes.Delete /closes #1666 * [manila-csi-plugin] use share.Name to identify volumes in pendingVolumes.Delete Co-authored-by: Alexis Ries <42094254+alexisries@users.noreply.github.com>

…from pendingVolumes (kubernetes#1667) * [manila-csi-plugin] in ControllerExpandVolume fix bad key for pendingVolumes.Delete /closes kubernetes#1666 * [manila-csi-plugin] use share.Name to identify volumes in pendingVolumes.Delete

[manila-csi-plugin] in ControllerExpandVolume fix bad key for pending…

ea0ec9e

…Volumes.Delete /closes kubernetes#1666

k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 12, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 12, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 12, 2021

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2021

k8s-ci-robot requested review from gouthampacha and tsmetana October 12, 2021 15:28

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 12, 2021

m-k8s changed the title ~~[manila-csi-plugin] ControllerExpandVolume: fix bad key for deleting from pendingVolumes~~ WIP: [manila-csi-plugin] ControllerExpandVolume: fix bad key for deleting from pendingVolumes Oct 12, 2021

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021

gouthampacha reviewed Oct 13, 2021

View reviewed changes

Comment thread pkg/csi/manila/controllerserver.go Outdated

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2021

[manila-csi-plugin] use share.Name to identify volumes in pendingVolu…

e274872

…mes.Delete

k8s-ci-robot assigned gman0 Oct 13, 2021

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2021

m-k8s changed the title ~~WIP: [manila-csi-plugin] ControllerExpandVolume: fix bad key for deleting from pendingVolumes~~ [manila-csi-plugin] ControllerExpandVolume: fix bad key for deleting from pendingVolumes Oct 13, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2021

k8s-ci-robot merged commit 4128209 into kubernetes:master Oct 13, 2021

m-k8s deleted the bug/1666 branch October 14, 2021 07:41

gman0 mentioned this pull request Oct 26, 2021

[manila-csi-plugin] ControllerExpandVolume: fix bad key for deleting from pendingVolumes (release-1.22) #1675

Merged

mandre mentioned this pull request Jan 19, 2023

OCPBUGS-6035: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.22 into release-4.9 openshift/cloud-provider-openstack#170

Merged

Conversation

m-k8s commented Oct 12, 2021

Uh oh!

k8s-ci-robot commented Oct 12, 2021

Uh oh!

k8s-ci-robot commented Oct 12, 2021

Uh oh!

k8s-ci-robot commented Oct 12, 2021

Uh oh!

theopenlab-ci Bot commented Oct 12, 2021

Uh oh!

Uh oh!

gouthampacha commented Oct 13, 2021

Uh oh!

theopenlab-ci Bot commented Oct 13, 2021

Uh oh!

gman0 commented Oct 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gman0 commented Oct 13, 2021

Uh oh!

k8s-ci-robot commented Oct 13, 2021

Uh oh!

gman0 commented Oct 13, 2021

Uh oh!

m-k8s commented Oct 13, 2021

Uh oh!

gman0 commented Oct 13, 2021

Uh oh!

ramineni commented Oct 13, 2021

Uh oh!

k8s-ci-robot commented Oct 13, 2021

Uh oh!

ramineni commented Oct 13, 2021

Uh oh!

k8s-ci-robot commented Oct 13, 2021

Uh oh!

ramineni commented Oct 13, 2021

Uh oh!

k8s-ci-robot commented Oct 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gman0 commented Oct 13, 2021 •

edited

Loading