[manila-csi-plugin] ControllerExpandVolume: fix bad key for deleting from pendingVolumes (release-1.22)#1675
Conversation
…from pendingVolumes (kubernetes#1667) * [manila-csi-plugin] in ControllerExpandVolume fix bad key for pendingVolumes.Delete /closes kubernetes#1666 * [manila-csi-plugin] use share.Name to identify volumes in pendingVolumes.Delete
k8s-ci-robot
added
release-note
|
PTAL @ramineni @lingxiankong @gouthampacha @lingxiankong could you please also cut a new image for this? |
|
/cc @alexisries |
|
@gman0: GitHub didn't allow me to request PR reviews from the following users: alexisries. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build failed.
|
|
Please note that the CI is expected to fail. |
|
Thanks for backporting this fix, @gman0 |
k8s-ci-robot
added
the
lgtm
|
@gman0 would you like to add manila jobs for 1.22 as well? |
|
Only cherrypick . Not a big change , so merging this. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ramineni The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@ramineni I think it's not necessary, there are no other backports planned. Unless some important bugfix occurs, like this one. The merge is blocked by openlab/cloud-provider-openstack-acceptance-test-csi-manila, can you please override? |
|
/override openlab/cloud-provider-openstack-acceptance-test-csi-manila |
|
@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-csi-manila DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lingxiankong this is merged. Could you please push updated image to https://hub.docker.com/r/k8scloudprovider/manila-csi-plugin ? Ref issue #1666 |
Hi @gman0 sure, no problem. Sorry for the late response, distracted by internal stuff. Will push a new image for manila-csi-plugin on stable v1.22 today. |
|
@lingxiankong thank you! |
6 participants
This is a backport of #1667 into the release-1.22 branch.
Cherry-picked from 4128209.
What this PR does / why we need it:
Without this fix,
ControllerExpandVolumebreaks locks on the affected volume. Controller plugin would need a manual restart (pod deletion).Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: