[cinder-csi-plugin] Remove redundant imagePullPolicy

[MPV]

Signed-off-by: Victor Sollerhed victor.sollerhed@pagero.com

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1598

...as done for cinder-csi-plugin chart version 1.4.x in: #1602

...but now for cinder-csi-plugin chart version 1.3.x.

...to ensure a smooth upgrade for anyone else passing Kubernetes v1.21 before v1.22.

Special notes for reviewers:

Release note:

NONE

[k8s-ci-robot]

Welcome @MPV!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @MPV. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jichenjc after the PR has been reviewed.
You can assign the PR to them by writing /assign @jichenjc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MPV]

@jichenjc PTAL. ❤️ This tiny backport should be quick to review.

[jichenjc]

/ok-to-test

[k8s-ci-robot]

@MPV: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-openstack-check	c430631	link	true	/test pull-cloud-provider-openstack-check

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jichenjc]

@MPV looks like this is valid error, seems related to go version ?

I0208 00:44:57.423] hack/verify-gofmt.sh
I0208 00:44:57.584] diff -u ./pkg/util/blockdevice/blockdevice_unsupported.go.orig ./pkg/util/blockdevice/blockdevice_unsupported.go
I0208 00:44:57.584] --- ./pkg/util/blockdevice/blockdevice_unsupported.go.orig	2022-02-08 00:44:57.448072780 +0000
I0208 00:44:57.585] +++ ./pkg/util/blockdevice/blockdevice_unsupported.go	2022-02-08 00:44:57.448072780 +0000
I0208 00:44:57.585] @@ -1,3 +1,4 @@
I0208 00:44:57.585] +//go:build !linux
I0208 00:44:57.585]  // +build !linux
I0208 00:44:57.585]  
I0208 00:44:57.585]  /*

[MPV]

@jichenjc My change is only related to the helm chart for cinder-csi-plugin.

Do you have any suggestions on how to fix the broken CI in this release-1.21 branch?
(to make patch releases possible, like for this PR)

[MPV]

@jichenjc I accidentally removed my fork, could you take a look at this new PR instead?
See #1781

(which also contains a fix from running ./hack/update-gofmt.sh which I hope should fix the CI failure).