Skip to content

[cinder-csi-plugin] Remove redundant imagePullPolicy#1784

Merged
k8s-ci-robot merged 3 commits intokubernetes:release-1.21from
pagero:release-1.21
Feb 17, 2022
Merged

[cinder-csi-plugin] Remove redundant imagePullPolicy#1784
k8s-ci-robot merged 3 commits intokubernetes:release-1.21from
pagero:release-1.21

Conversation

@MPV
Copy link
Copy Markdown
Contributor

@MPV MPV commented Feb 9, 2022 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1598

...as done for cinder-csi-plugin chart version 1.4.x in: #1602

...but now for cinder-csi-plugin chart version 1.3.x.

...to ensure a smooth upgrade for anyone else passing Kubernetes v1.21 before v1.22.

Special notes for reviewers:
Superseeds #1781 (which was accidentally closed).

Release note:

NONE

MPV added 2 commits February 7, 2022 16:24
@MPV
[cinder-csi-plugin] Remove redundant imagePullPolicy
c430631 
Fixes:
#1598

...as done for cinder-csi-plugin chart version 1.4.x in:
https://github.com/kubernetes/cloud-provider-openstack/pull/1602/files

...but now for cinder-csi-plugin chart version 1.3.x.

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
@MPV
Ran ./hack/update-gofmt.sh
9d6d132 
Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 9, 2022

Hi @MPV. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 9, 2022

@jichenjc Could you take a look?
Needs ok-to-test.
This is a new attempt at #1781 (with gofmt fix applied).

@jichenjc
Copy link
Copy Markdown
Contributor

jichenjc commented Feb 10, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2022
@MPV MPV mentioned this pull request Feb 12, 2022
Merged
@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

/test pull-cloud-provider-openstack-check

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

/retest

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

/retest

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

/test pull-cloud-provider-openstack-check

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

@jichenjc Any ideas? Seems this fails in other PRs too, for example as seen in #1775 (comment)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV MPV mentioned this pull request Feb 14, 2022
Merged
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV
Buffer os.Signal to avoid test error
e289c3f 
To fix test error:

   pkg/autohealing/cmd/root.go:81:3: misuse of unbuffered os.Signal
   channel as argument to signal.Notify

As done in newer branches in:
commit 043de59 / PR #1632

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

/test pull-cloud-provider-openstack-check

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

/retest

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022 •
edited
Loading

🤷

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

Skärmavbild 2022-02-14 kl 16 58 00

https://status.openlabtesting.org/builds/builds?job_name=cloud-provider-openstack-sanity-test-csi-cinder

@jichenjc Any idea on how to resolve the NODE_FAILURE above?

Do we need to backport the entire #1632 PR into the https://github.com/kubernetes/cloud-provider-openstack/tree/release-1.21 branch?

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@MPV
Copy link
Copy Markdown
Contributor Author

MPV commented Feb 14, 2022

I created #1791 as an attempt to cherry-pick #1632 into the release-1.21 branch, to see if it fixes these issues in the target branch.

@MPV MPV mentioned this pull request Feb 14, 2022
Closed
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 14, 2022

Build failed.

@ramineni
Copy link
Copy Markdown
Contributor

ramineni commented Feb 15, 2022

@MPV The above jobs are not required for this PR, will override them.

@ramineni
Copy link
Copy Markdown
Contributor

ramineni commented Feb 15, 2022

/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20
/override openlab/cloud-provider-openstack-multinode-csi-migration-test
/override openlab/cloud-provider-openstack-sanity-test-csi-cinder

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 15, 2022

@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance, openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19, openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20, openlab/cloud-provider-openstack-multinode-csi-migration-test, openlab/cloud-provider-openstack-sanity-test-csi-cinder

Details

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20
/override openlab/cloud-provider-openstack-multinode-csi-migration-test
/override openlab/cloud-provider-openstack-sanity-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Copy Markdown
Contributor

ramineni commented Feb 15, 2022

/override openlab/cloud-provider-openstack-test-occm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 15, 2022

@ramineni: Overrode contexts on behalf of ramineni: openlab/cloud-provider-openstack-test-occm

Details

In response to this:

/override openlab/cloud-provider-openstack-test-occm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramineni
Copy link
Copy Markdown
Contributor

ramineni commented Feb 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
@lingxiankong
Copy link
Copy Markdown
Contributor

lingxiankong commented Feb 17, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0eb798d into kubernetes:release-1.21 Feb 17, 2022
jingczhang pushed a commit to nokia/cloud-provider-openstack that referenced this pull request Jun 1, 2022
@MPV
[cinder-csi-plugin] Remove redundant imagePullPolicy (kubernetes#1784)
842c356 
* [cinder-csi-plugin] Remove redundant imagePullPolicy

Fixes:
kubernetes#1598

...as done for cinder-csi-plugin chart version 1.4.x in:
https://github.com/kubernetes/cloud-provider-openstack/pull/1602/files

...but now for cinder-csi-plugin chart version 1.3.x.

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

* Ran ./hack/update-gofmt.sh

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

* Buffer os.Signal to avoid test error

To fix test error:

   pkg/autohealing/cmd/root.go:81:3: misuse of unbuffered os.Signal
   channel as argument to signal.Notify

As done in newer branches in:
commit 043de59 / PR kubernetes#1632

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrigl chrigl Awaiting requested review from chrigl

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MPV @k8s-ci-robot @jichenjc @ramineni @lingxiankong