Skip to content

[cinder-csi-plugin] Backport-1.22:add 'force-create' into tag param to support force…#1831

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.22from
jichenjc:bug/1203-122
May 13, 2022
Merged

[cinder-csi-plugin] Backport-1.22:add 'force-create' into tag param to support force…#1831
k8s-ci-robot merged 1 commit intokubernetes:release-1.22from
jichenjc:bug/1203-122

Conversation

@jichenjc
Copy link
Copy Markdown
Contributor

@jichenjc jichenjc commented Apr 14, 2022 •
edited
Loading

… create

What this PR does / why we need it:

#1813
cherry pick for 1.22 version
also fixed some other necessary fix to pass test

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

add 'force-create' into tag param to support force create

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2022
@jichenjc jichenjc mentioned this pull request Apr 14, 2022
Merged
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2022

Build failed.

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Apr 14, 2022

/test openstack-cloud-csi-cinder-e2e-test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 14, 2022

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test openstack-cloud-csi-cinder-sanity-test-release-122
  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test openstack-cloud-csi-cinder-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Apr 14, 2022

/test openstack-cloud-csi-cinder-e2e-test-122

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 14, 2022

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test openstack-cloud-csi-cinder-sanity-test-release-122
  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test openstack-cloud-csi-cinder-e2e-test-122

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented Apr 15, 2022

@lingxiankong @ramineni can you help check this ? thanks

@ramineni
Copy link
Copy Markdown
Contributor

ramineni commented May 2, 2022

please add reference PR/commit id of master branch , easy to track for future reference.

@chrigl
Copy link
Copy Markdown
Contributor

chrigl commented May 12, 2022

/lgtm

.. from my point of view. Main PR is referenced in the description.
You could rename the PR to [cinder-csi-plugin] Backport-1.22: ... to clarify the purpose, and maybe add the release notes in the PR description.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@jichenjc jichenjc changed the title [cinder-csi-plugin]add 'force-create' into tag param to support force… [cinder-csi-plugin] Backport-1.22:add 'force-create' into tag param to support force… May 13, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 13, 2022
@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented May 13, 2022

/override openlab/cloud-provider-openstack-test-occm
/override openlab/cloud-provider-openstack-multinode-csi-migration-test
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.21

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2022

@jichenjc: Overrode contexts on behalf of jichenjc: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.21, openlab/cloud-provider-openstack-multinode-csi-migration-test, openlab/cloud-provider-openstack-test-occm

Details

In response to this:

/override openlab/cloud-provider-openstack-test-occm
/override openlab/cloud-provider-openstack-multinode-csi-migration-test
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented May 13, 2022

/override openlab/cloud-provider-openstack-sanity-test-csi-cinder
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2022

@jichenjc: Overrode contexts on behalf of jichenjc: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19, openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20, openlab/cloud-provider-openstack-sanity-test-csi-cinder

Details

In response to this:

/override openlab/cloud-provider-openstack-sanity-test-csi-cinder
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented May 13, 2022

/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2022

@jichenjc: Overrode contexts on behalf of jichenjc: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance

Details

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Copy Markdown
Contributor Author

jichenjc commented May 13, 2022

long waiting PR, got lgtm already
so I will merge this

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit f17fda8 into kubernetes:release-1.22 May 13, 2022
@unipolar
Copy link
Copy Markdown

unipolar commented Jun 15, 2022

@jichenjc could I ask you to build v.1.22.2 with the fix? there is no public build with the fix in 1.22 release yet.

@sphr2k
Copy link
Copy Markdown

sphr2k commented Sep 9, 2022

Bump :) @jichenjc Could you please trigger a v1.22.2 release containing this backport?

@sphr2k sphr2k mentioned this pull request Oct 19, 2022
Closed
@mandre mandre mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrigl chrigl Awaiting requested review from chrigl

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@chrigl chrigl

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jichenjc @k8s-ci-robot @ramineni @chrigl @unipolar @sphr2k