Skip to content

[cinder-csi-plugin]add 'force-create' into tag param to support force #1813

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jichenjc:bug/1812
Apr 3, 2022
Merged

[cinder-csi-plugin]add 'force-create' into tag param to support force #1813
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jichenjc:bug/1812

Conversation

@jichenjc
Copy link
Copy Markdown
Contributor

… create

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1812

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2022
@jichenjc jichenjc changed the title [cinder-csi-plugin]add 'force-create' into tag param to support force… WIP: [cinder-csi-plugin]add 'force-create' into tag param to support force Mar 17, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2022
@k8s-ci-robot k8s-ci-robot requested review from Fedosin and adisky March 17, 2022 10:21
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2022
@eumel8
Copy link
Copy Markdown
Contributor

eumel8 commented Mar 17, 2022

@jichenjc Works for me, snapshots are now created and deleted as well. Hopefully there will a backport to 1.22-release
Many thanks for the fast fix!

@jichenjc jichenjc changed the title WIP: [cinder-csi-plugin]add 'force-create' into tag param to support force [cinder-csi-plugin]add 'force-create' into tag param to support force Mar 18, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2022
@jichenjc
Copy link
Copy Markdown
Contributor Author

@ramineni @lingxiankong please help take a look~, thanks

@jichenjc
Copy link
Copy Markdown
Contributor Author

@eumel8 yes, will wait for the PR merged then backport to previous releases

@ramineni
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@lingxiankong
Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 29ac0c3 into kubernetes:master Apr 3, 2022
@eumel8
Copy link
Copy Markdown
Contributor

eumel8 commented Apr 14, 2022

@jichenjc you think about 1.22 backport? many thanks!

@jichenjc
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-1.22

@jichenjc
Copy link
Copy Markdown
Contributor Author

um... some repo use /cherry-pick works fine , guess we need define that :(

anyway, #1831 created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] volume snapshots are not created with force parameter

5 participants