[cinder-csi-plugin]add 'force-create' into tag param to support force…#1832
Conversation
k8s-ci-robot
added
release-note-none
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
please add cherry-pick PR number in description, easy for future reference. |
|
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19 |
|
@jichenjc: Overrode contexts on behalf of jichenjc: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance |
|
@jichenjc: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance |
|
@jichenjc: Overrode contexts on behalf of jichenjc: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance, openlab/cloud-provider-openstack-acceptance-test-keystone-authentication-authorization, openlab/cloud-provider-openstack-multinode-csi-migration-test DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.21 |
|
@jichenjc: Overrode contexts on behalf of jichenjc: openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.20, openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.21 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chrigl can you help check this? |
|
@jichenjc I did an e2e on our infra. Mostly looks good, but I have to check some weird failures. Stay tuned :) |
|
/lgtm my testfailures were just flaky. You could rename the PR to |
k8s-ci-robot
added
the
lgtm
|
Just one thing: We change default behavior from This could imho be done as a separate PR to master and backport. What do you think @jichenjc ? |
|
@chrigl I double checked, but I don't think I updated the default param .. where did you find the change in the code? |
|
When I understand your change correctly, the code was not working before anyways. So I think your change is good. The only thing I would change is this line: |
|
no, my change only honor the force-create flag .. which is removed as regression bug the code you saw might be test code? |
Indeed. That's a bit embarrassing :) /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrigl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
… create
What this PR does / why we need it:
#1813
1.23 version
also, there is a golint issue , fixed in this PR as well
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: