feat(sync): surface filtered op diagnostics#1041
Merged
Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
12 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67d37af0da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kunickiaj
force-pushed
the
05-05-feat_ui_manage_coordinator_sharing_domains
branch
from
a903538 to
6cb2339
Compare
kunickiaj
force-pushed
the
05-05-feat_sync_surface_filtered_op_diagnostics
branch
from
67d37af to
dd8ca3e
Compare
kunickiaj
changed the base branch from
05-05-feat_ui_manage_coordinator_sharing_domains
to
graphite-base/1041
kunickiaj
force-pushed
the
graphite-base/1041
branch
from
6cb2339 to
8fc074f
Compare
kunickiaj
force-pushed
the
05-05-feat_sync_surface_filtered_op_diagnostics
branch
from
dd8ca3e to
259d486
Compare
kunickiaj
force-pushed
the
05-05-feat_sync_surface_filtered_op_diagnostics
branch
from
259d486 to
3e131ed
Compare
Owner
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Surfaces filtered outbound sync diagnostics so operators can tell when data was not sent to a peer because of sharing-domain membership, visibility, or project filters.
The API/UI only expose bounded metadata (
reason,skipped_count,scope_id,project,visibility) and explicitly avoid payload-adjacent identifiers such as op/entity ids.Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Validation run:
pnpm exec vitest run packages/ui/src/tabs/sync/view-model.test.ts packages/viewer-server/src/index.test.tspnpm run tscpnpm run lint(only existing unrelated FeedItemCard info findings)pnpm run testgit diff --checkChecklist
pnpm run lintpasses for touched files)