feat: add password authentication and SSH key passphrase support#6
Merged
feat: add password authentication and SSH key passphrase support#6
Conversation
- Add --password flag for password-based authentication - Automatically detect and prompt for passphrases on encrypted SSH keys - Support passphrase entry for both explicit and default key paths - Check multiple default key types (ed25519, rsa, ecdsa, dsa) - Update all commands (exec, upload, download, ping) to support new auth methods - Add secure password/passphrase prompting using rpassword crate
- Update man page with password flag and passphrase information - Add authentication section to README with examples - Improve help text for identity flag to mention passphrase support - Keep version number unchanged at 0.3.0
- Replace hardcoded 'root' fallback with current user detection - Try USER, USERNAME, LOGNAME environment variables first - Use whoami crate to get system username as last resort - Add test to verify current user is used correctly - Ensures non-root users don't accidentally connect as root
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-P/--passwordflagKey Changes
Authentication Enhancements
-P/--passwordflag enables secure password promptingrpasswordcrate for secure password/passphrase input without echoDefault User Improvement
Documentation Updates
--helpoutput with new authentication optionsTest Plan
-Pflag