Conversation
And that these entries match, in order, ("Actors", "Actions", "Resources")
Contributor
|
Could you write a unit test to show a case where Check3D throws an exception? |
Contributor
Author
|
I was just thinking, maybe I should move the procedure "yamlFromFile" that I put in "Helpers.kt" to the package "utils", so that we can use it in the YAML.kt main function as well? By doing this, we could avoid code duplication. What do you think, @vrjuliao ? |
Contributor
|
Hi @Yowgf! it is a nice thing to think. |
vrjuliao
added a commit
that referenced
this pull request
May 12, 2021
* Code styling Specially usage of lower camelCase, for some functions, and then also moving stuff in main to a proper function in the class MatrixPrinter. * Refactoring and doc Some unused imports were removed, some things renamed, and so on. * Documentation * Ignore IntelliJ IDEA config folder * Error messages (#8) * init issue of error messages manipulation * error(messages): showing runtime error messages with the file coordinates * error(messages): DONE, but lacking unit tests * fix(error messages): DONE * fix(error messages): removing log files * fix(test): Unit tests description * fix(test): Unit tests function names * Fixing first line of printed YAML (#9) * Move to ./hapi folder (#11) These should be separated from the tests of other modules. Soon we plan to add the ./tasks folders, for unit tests that concern the "tasks" * Check that datamap matches 3D format (#10) * Checks if given datamap has 3 entries And that these entries match, in order, ("Actors", "Actions", "Resources") * Added check3D * Fixed names of classes * Renamed Check3D class * Moved check to inside the class * Added help to YAML testing * Fixtures to facilitate YAML tests * YAMLGenerator tests * Just change a comment * Delete the temp. result form yaml task * Fixing bug of generating HTML The HTML was only being generated if the actions were 'Reads', 'Updates', 'Deletes', which is obviously something not wanted. Also, added the DataMapOrderChecker checks. * Access matrix only displays atoms Co-authored-by: Yowgf <alexthomasmol@gmail.com> Co-authored-by: Yowgf <48073242+Yowgf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now, to generate the YAML file, the datamap of a Hapi program has to consist of exactly ("Actors", "Actions", "Resources"), in this order.
This update obligates the user not to generate ill-formed YAML files, by throwing an exception in that case.