Skip to content

Error messages#8

Merged
Yowgf merged 7 commits intomasterfrom
error-messages
Jan 29, 2021
Merged

Error messages#8
Yowgf merged 7 commits intomasterfrom
error-messages

Conversation

@vrjuliao
Copy link
Copy Markdown
Contributor

No description provided.

@vrjuliao vrjuliao requested a review from Yowgf January 28, 2021 17:49
Comment thread src/test/kotlin/unit/ParsingTest.kt Outdated
Comment on lines +78 to +79
@DisplayName("Invalid import statement - without comma")
fun invalidSyntaxWithoutComma(){
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"without" -> "missing"

Comment thread src/test/kotlin/unit/ParsingTest.kt Outdated
Comment on lines +101 to +102
@DisplayName("Invalid EXCEPT - without parenthesis")
fun invalidSyntaxWithoutParenthesis(){
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"without parenthesis" -> "missing curly braces"

Copy link
Copy Markdown
Contributor

@Yowgf Yowgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just renaming unit tests

@vrjuliao
Copy link
Copy Markdown
Contributor Author

Thank you @Yowgf , It's done.

@Yowgf Yowgf merged commit af841aa into master Jan 29, 2021
@Yowgf Yowgf deleted the error-messages branch January 29, 2021 17:29
vrjuliao added a commit that referenced this pull request May 12, 2021
* Code styling

Specially usage of lower camelCase, for some functions, and then also moving stuff in main to a proper function in the class MatrixPrinter.

* Refactoring and doc

Some unused imports were removed, some things renamed, and so on.

* Documentation

* Ignore IntelliJ IDEA config folder

* Error messages (#8)

* init issue of error messages manipulation

* error(messages): showing runtime error messages with the file coordinates

* error(messages): DONE, but lacking unit tests

* fix(error messages): DONE

* fix(error messages): removing log files

* fix(test): Unit tests description

* fix(test): Unit tests function names

* Fixing first line of printed YAML (#9)

* Move to ./hapi folder (#11)

These should be separated from the tests of other modules. Soon we plan to add the ./tasks folders, for unit tests that concern the "tasks"

* Check that datamap matches 3D format (#10)

* Checks if given datamap has 3 entries

And that these entries match, in order, ("Actors", "Actions", "Resources")

* Added check3D

* Fixed names of classes

* Renamed Check3D class

* Moved check to inside the class

* Added help to YAML testing

* Fixtures to facilitate YAML tests

* YAMLGenerator tests

* Just change a comment

* Delete the temp. result form yaml task

* Fixing bug of generating HTML

The HTML was only being generated if the actions were 'Reads', 'Updates', 'Deletes', which is obviously something not wanted.

Also, added the DataMapOrderChecker checks.

* Access matrix only displays atoms

Co-authored-by: Yowgf <alexthomasmol@gmail.com>
Co-authored-by: Yowgf <48073242+Yowgf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants