Skip to content

Conversation

@westonpace
Copy link
Member

@westonpace westonpace commented Apr 5, 2024

@westonpace westonpace force-pushed the feat/v2-python-bindings branch from 137c004 to e83702e Compare April 9, 2024 13:22
@westonpace westonpace marked this pull request as ready for review April 9, 2024 13:23
@westonpace westonpace requested review from eddyxu and wjones127 April 9, 2024 13:50
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 58.71560% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 80.99%. Comparing base (d189ca2) to head (7d8b83a).
Report is 1 commits behind head on main.

Files Patch % Lines
rust/lance-file/src/v2/reader.rs 47.94% 36 Missing and 2 partials ⚠️
rust/lance-io/src/object_writer.rs 55.55% 2 Missing and 2 partials ⚠️
rust/lance-file/src/v2/writer.rs 92.30% 0 Missing and 2 partials ⚠️
rust/lance-io/src/object_store.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
- Coverage   81.04%   80.99%   -0.06%     
==========================================
  Files         181      181              
  Lines       51279    51385     +106     
  Branches    51279    51385     +106     
==========================================
+ Hits        41560    41620      +60     
- Misses       7282     7344      +62     
+ Partials     2437     2421      -16     
Flag Coverage Δ
unittests 80.99% <58.71%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,188 @@
# Copyright (c) 2023. Lance Developers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 :)

Copy link
Member Author

@westonpace westonpace Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2177 😆


class LanceFileReader:
"""
A file reader for reading Lance files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this interface mostly internal utility? The public main interface is still pyarrow.Dataset?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is mainly for benchmarking / advanced use cases.

@westonpace westonpace force-pushed the feat/v2-python-bindings branch from b27f6af to 0ef20f1 Compare April 9, 2024 19:18
@westonpace westonpace merged commit 3f92746 into lance-format:main Apr 10, 2024
chebbyChefNEQ pushed a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants