chore: fix license headers #2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
wjones127
reviewed
Apr 10, 2024
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
I am in favor of these changes, but I'll let Lei approve.
eddyxu
approved these changes
Apr 10, 2024
Member
eddyxu
left a comment
eddyxu
left a comment
There was a problem hiding this comment.
I am fine with the change. pending CI fixes
westonpace
force-pushed
the
chore/fix-license-headers
branch
from
45ae9a4 to
78d55db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all license headers to SPDX (for brevity) and adds CI to verify the license headers (previously we only had checking on Rust, via ruff, and it was not checking the license text)
I also dropped the copyright year because it's unnecessary, I didn't want to have to try and fix it correctly, and other big projects have done so as well.
I also changed "Lance Developers" to "The Lance Authors" per the Linux Foundation guidelines.