Skip to content

fix: remove explain in sql#4428

Merged
wjones127 merged 2 commits intolance-format:mainfrom
wojiaodoubao:remove-explain-in-sql
Aug 12, 2025
Merged

fix: remove explain in sql#4428
wjones127 merged 2 commits intolance-format:mainfrom
wojiaodoubao:remove-explain-in-sql

Conversation

@wojiaodoubao
Copy link
Copy Markdown
Contributor

We can use something like EXPLAIN SELECT * FROM dataset or EXPLAIN ANALYZE SELECT * FROM dataset instead. I think it is more natural. So I'd like to remove explain_plan function.

@github-actions github-actions Bot added bug Something isn't working python labels Aug 11, 2025
@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

Hi @yanghua , could you help review this when you have time, thanks very much.

@yanghua
Copy link
Copy Markdown
Collaborator

yanghua commented Aug 11, 2025

Can you add some tests to show the equivalent ability?

@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

Can you add some tests to show the equivalent ability?

Sure, let me fix it.

@wojiaodoubao wojiaodoubao force-pushed the remove-explain-in-sql branch from 07fab6c to acae0d1 Compare August 11, 2025 12:30
@github-actions github-actions Bot added the java label Aug 11, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.89%. Comparing base (d6b4ea8) to head (b3d32a4).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4428      +/-   ##
==========================================
+ Coverage   81.86%   81.89%   +0.02%     
==========================================
  Files         302      302              
  Lines      122855   123172     +317     
  Branches   122855   123172     +317     
==========================================
+ Hits       100575   100867     +292     
- Misses      18485    18505      +20     
- Partials     3795     3800       +5     
Flag Coverage Δ
unittests 81.89% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread python/python/tests/test_dataset.py Outdated
Comment thread python/python/tests/test_dataset.py Outdated
@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

Hi @jackye1995 @yanghua , I have updated this pr. Please review when you have time, thanks !!!

Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wjones127 wjones127 merged commit 546073e into lance-format:main Aug 12, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working java python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants