fix: remove explain in sql#4428
Merged
wjones127 merged 2 commits intolance-format:mainfrom Aug 12, 2025
Merged
Conversation
Contributor
Author
|
Hi @yanghua , could you help review this when you have time, thanks very much. |
Collaborator
|
Can you add some tests to show the equivalent ability? |
Contributor
Author
Sure, let me fix it. |
07fab6c to
acae0d1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
==========================================
+ Coverage 81.86% 81.89% +0.02%
==========================================
Files 302 302
Lines 122855 123172 +317
Branches 122855 123172 +317
==========================================
+ Hits 100575 100867 +292
- Misses 18485 18505 +20
- Partials 3795 3800 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jackye1995
reviewed
Aug 11, 2025
jackye1995
reviewed
Aug 11, 2025
Contributor
Author
|
Hi @jackye1995 @yanghua , I have updated this pr. Please review when you have time, thanks !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use something like
EXPLAIN SELECT * FROM datasetorEXPLAIN ANALYZE SELECT * FROM datasetinstead. I think it is more natural. So I'd like to removeexplain_planfunction.