Skip to content

fix: remove remainder explain_plan method in Python#5085

Merged
westonpace merged 2 commits intolance-format:mainfrom
ddupg:fix/py-sql-plan
Oct 29, 2025
Merged

fix: remove remainder explain_plan method in Python#5085
westonpace merged 2 commits intolance-format:mainfrom
ddupg:fix/py-sql-plan

Conversation

@ddupg
Copy link
Copy Markdown
Contributor

@ddupg ddupg commented Oct 28, 2025

Closes: #5084

@github-actions github-actions Bot added bug Something isn't working python labels Oct 28, 2025
Change-Id: I417c9c67ef7d8fbe7a616f961fd42eba4ffcc3bd
@westonpace
Copy link
Copy Markdown
Member

It looks like this was intentionally removed in #4428

I'm not sure I have a strong opinion either way. CC @wojiaodoubao @jackye1995 @wjones127 from the other PR.

@ddupg
Copy link
Copy Markdown
Contributor Author

ddupg commented Oct 28, 2025

It looks like this was intentionally removed in #4428

I'm not sure I have a strong opinion either way. CC @wojiaodoubao @jackye1995 @wjones127 from the other PR.

So we should also remove the remainder Python code, right? I'll make the changes.

Change-Id: I92160e09b975e48322c2966c574cc45a4e325855
@ddupg ddupg changed the title fix: add missing explain_plan pymethod in SqlQuery fix: remove remainder explain_plan method in Python Oct 28, 2025
@yanghua
Copy link
Copy Markdown
Collaborator

yanghua commented Oct 28, 2025

duplicated with #5083 , but never mind, it's yours.

Copy link
Copy Markdown
Collaborator

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@westonpace westonpace merged commit e3cf56a into lance-format:main Oct 29, 2025
16 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing explain_plan pymethod in SqlQuery

3 participants