refactor: rework scalar index loading, training, and parsing into a plugin trait#4584
Merged
westonpace merged 10 commits intolance-format:mainfrom Sep 2, 2025
Merged
Conversation
wjones127
approved these changes
Aug 28, 2025
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
Cool to see the index types behind a trait.
Approved pending CI.
westonpace
force-pushed
the
refactor/scalar-index-plugins
branch
2 times, most recently
from
9ec646b to
28c3e0c
Compare
westonpace
force-pushed
the
refactor/scalar-index-plugins
branch
from
1d8599d to
d34c875
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4584 +/- ##
==========================================
- Coverage 80.93% 80.82% -0.11%
==========================================
Files 314 315 +1
Lines 117064 117713 +649
Branches 117064 117713 +649
==========================================
+ Hits 94749 95146 +397
- Misses 18931 19154 +223
- Partials 3384 3413 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I like the PR, great simplification |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…lugin trait (lance-format#4584) These operations were previously all done via match statements. This made it difficult to create new index types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These operations were previously all done via match statements. This made it difficult to create new index types.