ci: generate multiple fragments in forward compatibility tests and doc RowIdTreeMap.serialize…#5105
Merged
wjones127 merged 9 commits intolance-format:mainfrom Nov 5, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5105 +/- ##
==========================================
+ Coverage 81.77% 81.82% +0.04%
==========================================
Files 341 341
Lines 140933 140540 -393
Branches 140933 140540 -393
==========================================
- Hits 115255 114997 -258
+ Misses 21862 21735 -127
+ Partials 3816 3808 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddupg
force-pushed
the
feat/forward-compat-multi-frags
branch
4 times, most recently
from
346ccc3 to
871eb82
Compare
ddupg
changed the title
ddupg
force-pushed
the
feat/forward-compat-multi-frags
branch
7 times, most recently
from
5b6e676 to
b9eeb33
Compare
ddupg
changed the title
…nto stable Change-Id: Id60677e4214171588d7a50d0cb7fe10d1a7483f2
Change-Id: I882ee76b94fac0e30647204c41dd25cac664c090
ddupg
force-pushed
the
feat/forward-compat-multi-frags
branch
from
a3db46a to
a69bce9
Compare
Change-Id: If7e0bd74e7d4b2c9cca6c9b90dae3d76c5a8cd88
ddupg
force-pushed
the
feat/forward-compat-multi-frags
branch
from
23bf222 to
d67bfe0
Compare
ddupg
force-pushed
the
feat/forward-compat-multi-frags
branch
2 times, most recently
from
ae52700 to
4838c10
Compare
Change-Id: I27ce298f8c7ce280c75309ff390e86e2a5112269
ddupg
force-pushed
the
feat/forward-compat-multi-frags
branch
from
4838c10 to
00ff7da
Compare
Contributor
Author
|
Forward compatibility tests
I've also attempted to fix above problems here. Please @jackye1995 help review this. |
Contributor
Author
|
The failed tests |
Contributor
Author
|
@wjones127 @westonpace could please help review this? |
wjones127
approved these changes
Nov 5, 2025
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
Looks good. I have some minor comments I can change before I merge.
Comment on lines
+232
to
+235
| # Dataset::load_manifest does not do retain_supported_indices | ||
| # so this can only work with no cache | ||
| session = lance.Session(index_cache_size_bytes=0, metadata_cache_size_bytes=0) | ||
| ds = lance.dataset(tmp_path, session=session) |
Contributor
There was a problem hiding this comment.
🤦 We should really fix this bug.
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…c RowIdTreeMap.serialize… (lance-format#5105) …_into stable Closes: lance-format#5093 This PR made the following changes: 1. doc RowIdTreeMap.serialize_info as stable, which was used in bitmap index 2. make sure that the forward compatibility tests datasets have multiple fragments to guarantee older versions Lance can correctly load bitmap index. 3. make sure backward compatibility test `test_old_btree_bitmap_indices` use bitmap index 4. fix fails introduced by lance-format#4906 --------- Co-authored-by: Will Jones <willjones127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_into stable
Closes: #5093
This PR made the following changes:
test_old_btree_bitmap_indicesuse bitmap index