feat!: make handling of null semantics consistent in indexes#4812
Closed
ddupg wants to merge 1 commit intolance-format:mainfrom
Closed
feat!: make handling of null semantics consistent in indexes#4812ddupg wants to merge 1 commit intolance-format:mainfrom
ddupg wants to merge 1 commit intolance-format:mainfrom
Conversation
…sabling indexes Change-Id: Ia0f49a8baa1d78d8fcd69030fa951a1cb9a79e39
github-actions
Bot
added
enhancement
jackye1995
changed the title
westonpace
reviewed
Sep 25, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Thanks for looking into this. I'm happy we are finally getting these consistent. I agree that this way (aligning with SQL / DF) is the best approach.
| SargableQuery::Equals(value) => arrow_ord::cmp::eq(self.values(), &value.to_scalar()?)?, | ||
| SargableQuery::IsNull() => arrow::compute::is_null(self.values())?, | ||
| SargableQuery::IsIn(values) => { | ||
| let mut has_null = false; |
Member
There was a problem hiding this comment.
We should remove this flag as well?
Member
|
I'm surprised that |
Contributor
Author
|
Thanks #4815 of @westonpace for fixing this issue, I closed this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4814