refactor: cowardly refuse to use scalar indexes on expressions with null literals#4815
Merged
westonpace merged 2 commits intolance-format:mainfrom Sep 25, 2025
Merged
Conversation
jackye1995
approved these changes
Sep 25, 2025
| expected: Option<IndexedExpression>, | ||
| optimize: bool, | ||
| ) { | ||
| println!("Checking expression: {}", expr); |
Contributor
There was a problem hiding this comment.
Should remove the println?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4815 +/- ##
==========================================
+ Coverage 80.87% 80.88% +0.01%
==========================================
Files 328 328
Lines 129406 129461 +55
Branches 129406 129461 +55
==========================================
+ Hits 104657 104718 +61
+ Misses 21069 21065 -4
+ Partials 3680 3678 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…ull literals (lance-format#4815) The current search logic with scalar indexes assumes that the list returned by a scalar index contains either: * All the true rows and all other rows are false * All the false rows and all other rows are true This is a problem when dealing with nulls. This is related to lance-format#4756 This PR doesn't fix lance-format#4756 however it does help avoid some areas where we are definitely likely to do the wrong thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current search logic with scalar indexes assumes that the list returned by a scalar index contains either:
This is a problem when dealing with nulls. This is related to #4756
This PR doesn't fix #4756 however it does help avoid some areas where we are definitely likely to do the wrong thing.