Skip to content

refactor!: use org.lance namespace for java package#5339

Merged
jackye1995 merged 3 commits intolance-format:mainfrom
jackye1995:java-renames
Nov 25, 2025
Merged

refactor!: use org.lance namespace for java package#5339
jackye1995 merged 3 commits intolance-format:mainfrom
jackye1995:java-renames

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

Looks like lance-namespace needs to be renamed first, and also I might need to separate lance-namespace integrations to a separated lance-namespace-impls for all the other non-rest non-dir implementations. Publish the draft first while thinking about it.

@jackye1995 jackye1995 marked this pull request as draft November 25, 2025 08:10
@jackye1995 jackye1995 changed the title refactor: use org.lance namespace for java package refactor!: use org.lance namespace for java package Nov 25, 2025
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

private static native Dataset createWithFfiSchema(
long arrowSchemaMemoryAddress,
String path,
Optional<Integer> maxRowsPerFile,
Optional<Integer> maxRowsPerGroup,

P1 Badge Update JNI exports to new package path

The Java bindings have moved to the org.lance package and still declare native entrypoints such as createWithFfiSchema on org.lance.Dataset, but the corresponding JNI functions in java/lance-jni/src/blocking_dataset.rs remain exported as Java_com_lancedb_lance_* (e.g., line 327) instead of Java_org_lance_*. With this mismatch, any invocation of these native methods will fail at runtime with UnsatisfiedLinkError because the JVM cannot find the expected native symbols for the new package.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jackye1995
Copy link
Copy Markdown
Contributor Author

I think given we have moved the main LanceNamespace trait in rust to core repo, we should also move the python and java one to the core repo. This will make lance-namespace repo responsible for 2 aspects: (1) codegen of the request response models in different languages, (2) all language specific namespace implementations except the directory and rest namespaces, which we will maintain in the main repo through rust binding.

Let me know what you think @majin1102

@jackye1995 jackye1995 requested a review from majin1102 November 25, 2025 08:25
@jackye1995 jackye1995 marked this pull request as ready for review November 25, 2025 08:25
@jackye1995
Copy link
Copy Markdown
Contributor Author

This means we can merge this repo as is, and I will do another PR to do the migration of the LanceNamespace interfaces in python and java

@jackye1995 jackye1995 merged commit 2b09ace into lance-format:main Nov 25, 2025
7 checks passed
@majin1102
Copy link
Copy Markdown
Contributor

I think given we have moved the main LanceNamespace trait in rust to core repo, we should also move the python and java one to the core repo. This will make lance-namespace repo responsible for 2 aspects: (1) codegen of the request response models in different languages, (2) all language specific namespace implementations except the directory and rest namespaces, which we will maintain in the main repo through rust binding.

Let me know what you think @majin1102

Sorry for being late,I've been on a business trip these past two days. I'm wondering if doing this would undermine the neutrality of the namespace and its ability to adapt to multiple formats?

In fact, we are considering replacing the catalog with a namespace at the product layer to adapt to more AI-native scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants