Skip to content

refactor!: use org.lance namespace for java package #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackye1995 merged 3 commits into from
Nov 25, 2025
Merged

refactor!: use org.lance namespace for java package #5339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16675b4
refactor: use org.lance namespace for java package
jackye1995 Nov 25, 2025
899b596
update
jackye1995 Nov 25, 2025
c59848b
update jni
jackye1995 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/create_rc_discussion.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ pip install --pre --extra-index-url https://pypi.fury.io/lance-format/pylance==$
Add to your \`pom.xml\`:
\`\`\`xml
<dependency>
<groupId>com.lancedb</groupId>
<artifactId>lance</artifactId>
<groupId>org.lance</groupId>
<artifactId>lance-core</artifactId>
<version>${RC_VERSION}</version>
</dependency>
\`\`\`
Expand Down
2 changes: 1 addition & 1 deletion java/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Introduce the Lance SDK Java Maven dependency(It is recommended to choose the la

```shell
<dependency>
<groupId>com.lancedb</groupId>
<groupId>org.lance</groupId>
<artifactId>lance-core</artifactId>
<version>0.35.0</version>
</dependency>
Expand Down
21 changes: 9 additions & 12 deletions java/lance-jni/src/blocking_blob.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use lance::dataset::BlobFile;
use std::mem::transmute;
use std::sync::Arc;

const BLOB_FILE_CLASS: &str = "com/lancedb/lance/BlobFile";
const BLOB_FILE_CLASS: &str = "org/lance/BlobFile";
const BLOB_FILE_CTOR_SIG: &str = "()V";
const NATIVE_BLOB: &str = "nativeBlobHandle";

Expand All @@ -35,7 +35,7 @@ impl From<BlobFile> for BlockingBlobFile {
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_Dataset_nativeTakeBlobs<'local>(
pub extern "system" fn Java_org_lance_Dataset_nativeTakeBlobs<'local>(
mut env: JNIEnv<'local>,
jdataset: JObject,
row_ids_obj: JObject, // List<Long>
Expand Down Expand Up @@ -87,7 +87,7 @@ fn transform_vec<'local>(
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_Dataset_nativeTakeBlobsByIndices<'local>(
pub extern "system" fn Java_org_lance_Dataset_nativeTakeBlobsByIndices<'local>(
mut env: JNIEnv<'local>,
jdataset: JObject,
row_indices_obj: JObject, // List<Long>
Expand Down Expand Up @@ -123,7 +123,7 @@ fn inner_take_blobs_by_indices<'local>(
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_BlobFile_nativeRead(
pub extern "system" fn Java_org_lance_BlobFile_nativeRead(
mut env: JNIEnv,
jblob: JObject,
) -> jbyteArray {
Expand All @@ -148,7 +148,7 @@ fn inner_blob_read<'local>(env: &mut JNIEnv<'local>, jblob: JObject) -> Result<J
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_BlobFile_nativeReadUpTo<'local>(
pub extern "system" fn Java_org_lance_BlobFile_nativeReadUpTo<'local>(
mut env: JNIEnv<'local>,
jblob: JObject,
len: jint,
Expand Down Expand Up @@ -178,7 +178,7 @@ fn inner_blob_read_up_to<'local>(
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_BlobFile_nativeSeek(
pub extern "system" fn Java_org_lance_BlobFile_nativeSeek(
mut env: JNIEnv,
jblob: JObject,
new_cursor: jlong,
Expand All @@ -193,7 +193,7 @@ fn inner_blob_seek(env: &mut JNIEnv, jblob: JObject, new_cursor: jlong) -> Resul
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_BlobFile_nativeTell(
pub extern "system" fn Java_org_lance_BlobFile_nativeTell(
mut env: JNIEnv,
jblob: JObject,
) -> jlong {
Expand All @@ -206,7 +206,7 @@ fn inner_blob_tell(env: &mut JNIEnv, jblob: JObject) -> Result<u64> {
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_BlobFile_nativeSize(
pub extern "system" fn Java_org_lance_BlobFile_nativeSize(
mut env: JNIEnv,
jblob: JObject,
) -> jlong {
Expand All @@ -219,10 +219,7 @@ fn inner_blob_size(env: &mut JNIEnv, jblob: JObject) -> Result<u64> {
}

#[no_mangle]
pub extern "system" fn Java_com_lancedb_lance_BlobFile_nativeClose(
mut env: JNIEnv,
jblob: JObject,
) {
pub extern "system" fn Java_org_lance_BlobFile_nativeClose(mut env: JNIEnv, jblob: JObject) {
ok_or_throw_without_return!(env, inner_blob_close(&mut env, jblob));
}

Expand Down
Loading