Skip to content

test: fix tests broken by pandas 3 release#5786

Merged
Xuanwo merged 1 commit intolance-format:mainfrom
westonpace:test/pandas-3-compat
Jan 22, 2026
Merged

test: fix tests broken by pandas 3 release#5786
Xuanwo merged 1 commit intolance-format:mainfrom
westonpace:test/pandas-3-compat

Conversation

@westonpace
Copy link
Copy Markdown
Member

Pandas 3 just released. This caused some tests to fail.

@github-actions
Copy link
Copy Markdown
Contributor

PR Review

Summary: Simple test fix for Pandas 3 compatibility. No issues found.

The change adds check_dtype=False to two assert_frame_equal calls in test_duckdb. This is an appropriate fix when Pandas 3 changes internal dtype handling for filter operations while the actual values remain correct.

Verdict: ✅ LGTM - straightforward compatibility fix.

drop=True
)
tm.assert_frame_equal(actual, expected)
tm.assert_frame_equal(actual, expected, check_dtype=False)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duckdb is still using the old "object based strings" approach when creating a dataframe. Lance (presumably via pyarrow) now creates "arrow based strings" when creating a dataframe.

@Xuanwo
Copy link
Copy Markdown
Collaborator

Xuanwo commented Jan 22, 2026

There are tests failed for

FAILED python/tests/test_scalar_index.py::test_fts_multi_match_query - AssertionError: 
Arrays are not equal
Column title values don't match
Mismatched elements: 2 / 2 (100%)
Mismatch at indices:
 [0]: title common (ACTUAL), title vector (DESIRED)
 [1]: title vector (ACTUAL), title common (DESIRED)
 ACTUAL: array(['title common', 'title vector'], dtype=object)
 DESIRED: array(['title vector', 'title common'], dtype=object)
FAILED python/tests/test_scalar_index.py::test_distributed_fts_multi_match_validation - AssertionError: 
Arrays are not equal
Column title values don't match
Mismatched elements: 2 / 2 (100%)
Mismatch at indices:
 [0]: title vector (ACTUAL), title common (DESIRED)
 [1]: title common (ACTUAL), title vector (DESIRED)
 ACTUAL: array(['title vector', 'title common'], dtype=object)
 DESIRED: array(['title common', 'title vector'], dtype=object)

@Xuanwo
Copy link
Copy Markdown
Collaborator

Xuanwo commented Jan 22, 2026

I'm going to merge this PR first and working on others.

@Xuanwo Xuanwo merged commit c2d74fa into lance-format:main Jan 22, 2026
12 of 16 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 23, 2026
Pandas 3 just released.  This caused some tests to fail.
majin1102 pushed a commit to majin1102/lance that referenced this pull request Jan 23, 2026
Pandas 3 just released.  This caused some tests to fail.
jackye1995 pushed a commit that referenced this pull request Jan 23, 2026
Pandas 3 just released.  This caused some tests to fail.
vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
Pandas 3 just released.  This caused some tests to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants