test: fix tests broken by pandas 3 release#5786
Merged
Xuanwo merged 1 commit intolance-format:mainfrom Jan 22, 2026
Merged
Conversation
Contributor
PR ReviewSummary: Simple test fix for Pandas 3 compatibility. No issues found. The change adds Verdict: ✅ LGTM - straightforward compatibility fix. |
westonpace
commented
Jan 22, 2026
| drop=True | ||
| ) | ||
| tm.assert_frame_equal(actual, expected) | ||
| tm.assert_frame_equal(actual, expected, check_dtype=False) |
Member
Author
There was a problem hiding this comment.
Duckdb is still using the old "object based strings" approach when creating a dataframe. Lance (presumably via pyarrow) now creates "arrow based strings" when creating a dataframe.
Xuanwo
approved these changes
Jan 22, 2026
Collaborator
|
There are tests failed for |
Collaborator
|
I'm going to merge this PR first and working on others. |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 23, 2026
Pandas 3 just released. This caused some tests to fail.
majin1102
pushed a commit
to majin1102/lance
that referenced
this pull request
Jan 23, 2026
Pandas 3 just released. This caused some tests to fail.
jackye1995
pushed a commit
that referenced
this pull request
Jan 23, 2026
Pandas 3 just released. This caused some tests to fail.
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
Pandas 3 just released. This caused some tests to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pandas 3 just released. This caused some tests to fail.