Skip to content

test: fix tests broken by pandas 3 release #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
Jan 22, 2026
Merged

test: fix tests broken by pandas 3 release #5786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/python/tests/test_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,12 +299,12 @@ def test_duckdb(tmp_path):
expected = expected[(expected.price > 20.0) & (expected.price <= 90)].reset_index(
drop=True
)
tm.assert_frame_equal(actual, expected)
tm.assert_frame_equal(actual, expected, check_dtype=False)
Copy link
Copy Markdown
Member Author

@westonpace westonpace Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duckdb is still using the old "object based strings" approach when creating a dataframe. Lance (presumably via pyarrow) now creates "arrow based strings" when creating a dataframe.


actual = duckdb.query("SELECT id, meta, price FROM ds WHERE meta=='aa'").to_df()
expected = duckdb.query("SELECT id, meta, price FROM ds").to_df()
expected = expected[expected.meta == "aa"].reset_index(drop=True)
tm.assert_frame_equal(actual, expected)
tm.assert_frame_equal(actual, expected, check_dtype=False)


def test_struct_field_order(tmp_path):
Expand Down
Loading