Skip to content

feat: add blob handling support for fragment#5801

Merged
Xuanwo merged 2 commits intomainfrom
luban/hope-panda
Jan 26, 2026
Merged

feat: add blob handling support for fragment#5801
Xuanwo merged 2 commits intomainfrom
luban/hope-panda

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Jan 26, 2026

This PR will add blob handling support for fragment


Parts of this PR were drafted with assistance from Codex (with gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.

@github-actions github-actions Bot added enhancement New feature or request python labels Jan 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@Xuanwo Xuanwo changed the title feat: Add blob handling support for fragment feat: add blob handling support for fragment Jan 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

Overall: This PR correctly adds blob handling support to fragment scanning, mirroring the existing Dataset scanner implementation. The changes are well-structured and consistent with the codebase patterns.

Minor Suggestion (P2)

The test covers fragment.scanner().to_table() and fragment.to_table(), but fragment.to_batches() also receives the new blob_handling parameter. Consider adding a brief test case for to_batches as well for completeness:

batches = list(fragment.to_batches(columns=["blobs"], blob_handling="all_binary"))
assert pa.Table.from_batches(batches).column("blobs").to_pylist() == values

This is a minor suggestion - the current coverage is likely sufficient since to_batches simply delegates to scanner().


LGTM otherwise. The implementation correctly follows the existing pattern in dataset.rs.

@Xuanwo Xuanwo merged commit bb361de into main Jan 26, 2026
12 checks passed
@Xuanwo Xuanwo deleted the luban/hope-panda branch January 26, 2026 10:46
Xuanwo added a commit that referenced this pull request Jan 26, 2026
This PR will add blob handling support for fragment

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
Xuanwo added a commit that referenced this pull request Jan 26, 2026
This PR will add blob handling support for fragment

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
jackye1995 pushed a commit that referenced this pull request Jan 26, 2026
This PR will add blob handling support for fragment

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
jackye1995 pushed a commit that referenced this pull request Jan 27, 2026
This PR will add blob handling support for fragment

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
This PR will add blob handling support for fragment

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants