feat: add blob handling support for fragment#5801
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Code ReviewOverall: This PR correctly adds blob handling support to fragment scanning, mirroring the existing Dataset scanner implementation. The changes are well-structured and consistent with the codebase patterns. Minor Suggestion (P2)The test covers batches = list(fragment.to_batches(columns=["blobs"], blob_handling="all_binary"))
assert pa.Table.from_batches(batches).column("blobs").to_pylist() == valuesThis is a minor suggestion - the current coverage is likely sufficient since LGTM otherwise. The implementation correctly follows the existing pattern in |
This PR will add blob handling support for fragment --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will add blob handling support for fragment --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will add blob handling support for fragment --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will add blob handling support for fragment --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will add blob handling support for fragment --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will add blob handling support for fragment
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.