fix: don't drop field metadata on merge insert path#5936
Merged
jackye1995 merged 4 commits intorelease/v2.0from Feb 12, 2026
Merged
fix: don't drop field metadata on merge insert path#5936jackye1995 merged 4 commits intorelease/v2.0from
jackye1995 merged 4 commits intorelease/v2.0from
Conversation
There are various ways to write data and several of them are failing for JSON data at the moment because it requires a conversion from logical to physical representation. I'd like to rework this more generally but I want to get the current implementation working first. This fixes one of the merge_insert paths which is currently failing because the field metadata is lost as part of the operation (and so the data appears to be a normal string column and is not converted)
Contributor
Code ReviewSummary: This backport correctly fixes a bug where field metadata (needed for JSON extension types) was being lost during merge_insert operations. The FixThe one-line Rust change is correct: // Before: Dropped field metadata
Arc::new(arrow_schema::Field::new(field.name(), field.data_type().clone(), field.is_nullable()))
// After: Preserves all field attributes including metadata
Arc::new(field.clone())Using Test CoverageGood test coverage added for:
No issues identified. Clean backport of the original fix. |
This will ensure JSON columns are properly converted in paths like add_columns
Cherry-pick from main to fix CI recursion limit error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Link: https://github.com/lance-format/lance/actions/runs/21917803271 Summary of failure: - build-no-lock failed because rustc 1.90.0 is too old for updated aws-smithy dependencies (requires 1.91). Fixes applied: - Bumped the pinned Rust toolchain to 1.91.0 to satisfy dependency MSRV in no-lock builds. --------- Co-authored-by: Jack Ye <yezhaoqin@gmail.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
jackye1995
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #5927
This PR backports the changes from the original PR to the release/v2.0 branch.