Conversation
PR Review: ci: avoid shellexpand in lance-ioSummary: This PR replaces the P1 - Missing Unit Tests for
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This PR will replace #5985 since we don't need a new dep ## Summary - remove `shellexpand` from workspace and `lance-io` dependencies - replace tilde expansion in `lance-io` with `std::env::home_dir`-based logic - keep support for `~` and `~/...` paths (plus `~\\...` on Windows) - update lockfile to drop `shellexpand` ## Validation - `cargo check -p lance-io` - `cargo test -p lance-io test_tilde_expansion -- --nocapture`
Link to failing workflow run: https://github.com/lance-format/lance/actions/runs/22272601908/job/64429623103?pr=5980
Summary of failures:
Fixes applied: