chore(io): remove shellexpand and use std::env::home_dir#5987
Conversation
PR ReviewP1: The new
On Windows, it returns the value of the Recommendation: Since
Example fix: fn expand_tilde_path(path: &str) -> Option<std::path::PathBuf> {
let home_dir = dirs::home_dir()?;
// ... rest unchanged
}This would require adding |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
westonpace
left a comment
There was a problem hiding this comment.
Thanks for figuring this out!
This PR will replace #5985 since we don't need a new dep
Summary
shellexpandfrom workspace andlance-iodependencieslance-iowithstd::env::home_dir-based logic~and~/...paths (plus~\\...on Windows)shellexpandValidation
cargo check -p lance-iocargo test -p lance-io test_tilde_expansion -- --nocapture