chore(io): remove shellexpand and use std::env::home_dir#5986
Closed
Xuanwo wants to merge 1 commit intolance-format:mainfrom
Closed
chore(io): remove shellexpand and use std::env::home_dir#5986Xuanwo wants to merge 1 commit intolance-format:mainfrom
Xuanwo wants to merge 1 commit intolance-format:mainfrom
Conversation
Collaborator
Author
|
Superseded by #5987 from origin branch. |
Contributor
PR ReviewP0 - Use of deprecated The new The workspace already has the dirs = "6.0.0"Suggested fix in fn expand_tilde_path(path: &str) -> Option<std::path::PathBuf> {
let home_dir = dirs::home_dir()?; // Use dirs crate instead of std::env::home_dir
if path == "~" {
return Some(home_dir);
}
// ... rest unchanged
}And add to dirs.workspace = trueThis avoids the deprecation warning while using the same underlying implementation that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shellexpandfrom workspace andlance-iodependencieslance-iowithstd::env::home_dir-based logic~and~/...paths (plus~\\...on Windows)shellexpandValidation
cargo check -p lance-iocargo test -p lance-io test_tilde_expansion -- --nocapture