Skip to content

docs: align 2.2 encoding docs and nested add-column notes#6038

Merged
Xuanwo merged 1 commit intomainfrom
xuanwo/review-2-2-doc-coverage
Feb 27, 2026
Merged

docs: align 2.2 encoding docs and nested add-column notes#6038
Xuanwo merged 1 commit intomainfrom
xuanwo/review-2-2-doc-coverage

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Feb 27, 2026

Cover more 2.2 changes in our docs to get users perpared.


Parts of this PR were drafted with assistance from Codex (with gpt-5.3) and fully reviewed and edited by me. I take full responsibility for all changes.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

Review Summary: Documentation-only PR - LGTM ✅

This PR improves documentation clarity for Lance 2.2 encoding features. I verified the key claims against the codebase:

  1. RLE BlockCompressor: Confirmed - RleEncoder implements BlockCompressor trait (rust/lance-encoding/src/encodings/physical/rle.rs:393)

  2. General BlockCompressor: Confirmed - CompressedBufferEncoder implements BlockCompressor (rust/lance-encoding/src/encodings/physical/block.rs:627)

  3. VariablePackedStruct: Confirmed - defined in protos/encodings_v2_1.proto:425 with field number 13

No P0/P1 issues found. The documentation changes are accurate and improve clarity for:

  • Miniblock metadata wording for final chunk decoding
  • PackedStruct vs VariablePackedStruct distinction by version
  • Compression capability matrix updates for 2.2

Reviewed via automated analysis

@Xuanwo Xuanwo merged commit be8cea3 into main Feb 27, 2026
8 checks passed
@Xuanwo Xuanwo deleted the xuanwo/review-2-2-doc-coverage branch February 27, 2026 12:15
wjones127 pushed a commit to wjones127/lance that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants