Skip to content

refactor: move DatasetIndexExt out of lance-index#6280

Merged
Xuanwo merged 5 commits intomainfrom
xuanwo/issue-6221-move-dataset-index-api
Mar 26, 2026
Merged

refactor: move DatasetIndexExt out of lance-index#6280
Xuanwo merged 5 commits intomainfrom
xuanwo/issue-6221-move-dataset-index-api

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Mar 24, 2026

This moves DatasetIndexExt and the dataset-facing index segment types out of lance-index and into lance, so the public dataset index management API lives in the dataset layer instead of the lower-level index implementation crate.

Close #6221

@github-actions
Copy link
Copy Markdown
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@github-actions
Copy link
Copy Markdown
Contributor

Review

Clean refactoring — no P0/P1 issues found.

Reviewed the full diff across all 55 files. The trait and type definitions in the new lance/src/index/api.rs are faithful copies from lance-index, and all workspace-internal import paths have been updated consistently. Nice catch on the "indies" → "indices" typo fix in the doc comment.

One minor note: lance-index is a published crate (no publish = false in Cargo.toml), so removing DatasetIndexExt, IndexSegment, and IndexSegmentPlan from its public API is a semver-breaking change for any external consumers. The PR title already signals this, but worth confirming that downstream users (e.g. Python/Java bindings, lance-namespace-impls) are all accounted for — which they appear to be from the diff.

LGTM.

@Xuanwo Xuanwo changed the title Move DatasetIndexExt out of lance-index refactor!: move DatasetIndexExt out of lance-index Mar 24, 2026
@Xuanwo Xuanwo changed the title refactor!: move DatasetIndexExt out of lance-index refactor: move DatasetIndexExt out of lance-index Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 96.73913% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/index/api.rs 96.73% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Xuanwo Xuanwo merged commit ee324f4 into main Mar 26, 2026
29 checks passed
@Xuanwo Xuanwo deleted the xuanwo/issue-6221-move-dataset-index-api branch March 26, 2026 10:35
Xuanwo added a commit that referenced this pull request Mar 26, 2026
This fixes the main-branch CI failure introduced after #6280 moved
`DatasetIndexExt` into `lance`. `rust/lance-namespace-impls/src/dir.rs`
still imported and referenced the old `lance_index::DatasetIndexExt`
path, which broke the Java JNI workflow when it compiled the namespace
implementation.
wjones127 pushed a commit to wjones127/lance that referenced this pull request Mar 29, 2026
This moves `DatasetIndexExt` and the dataset-facing index segment types
out of `lance-index` and into `lance`, so the public dataset index
management API lives in the dataset layer instead of the lower-level
index implementation crate.

Close lance-format#6221
wjones127 pushed a commit to wjones127/lance that referenced this pull request Mar 29, 2026
…#6302)

This fixes the main-branch CI failure introduced after lance-format#6280 moved
`DatasetIndexExt` into `lance`. `rust/lance-namespace-impls/src/dir.rs`
still imported and referenced the old `lance_index::DatasetIndexExt`
path, which broke the Java JNI workflow when it compiled the namespace
implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move DatasetIndexExt out of lance-index

2 participants