fix: restore namespace build after DatasetIndexExt move#6302
Merged
Conversation
BubbleCal
approved these changes
Mar 26, 2026
Contributor
ReviewClean, minimal fix. The import path updates from LGTM. 🤖 Generated with Claude Code |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Mar 29, 2026
…#6302) This fixes the main-branch CI failure introduced after lance-format#6280 moved `DatasetIndexExt` into `lance`. `rust/lance-namespace-impls/src/dir.rs` still imported and referenced the old `lance_index::DatasetIndexExt` path, which broke the Java JNI workflow when it compiled the namespace implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the main-branch CI failure introduced after #6280 moved
DatasetIndexExtintolance.rust/lance-namespace-impls/src/dir.rsstill imported and referenced the oldlance_index::DatasetIndexExtpath, which broke the Java JNI workflow when it compiled the namespace implementation.