fix: use issubclass in the pool creation

[zzzming]

see the issue #10231

When LANGFLOW_DB_CONNECTION_SETTINGS={"poolclass": "NullPool"} , the langflow fails on the sql pool initialization. Error: Pool.init() missing 1 required positional argument: 'creator'
timestamp='2025-10-11T02:29:03.785753Z' level='error' event="Unhandled error during cleanup: Pool.init() missing 1 required positional argument: 'creator'"

On line 131 in service.py:131, the code tries to instantiate pool_class() to check if it's an instance of sa.pool.Pool, but pool classes like NullPool require a creator argument. The check should use issubclass() instead of isinstance(). The environment variable LANGFLOW_DB_CONNECTION_SETTINGS={"poolclass": "NullPool"} is triggering this bug.

Summary by CodeRabbit

• Bug Fixes
  • Improved validation of database pool configuration to prevent errors when an invalid pool class is provided.
  • Now safely ignores invalid pool settings and logs an error instead of failing, enhancing stability during database engine initialization.
  • Ensures compatibility with supported pool classes for more reliable startup and connection handling.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Refines poolclass handling in database engine creation: retrieves the pool class from sa.pool, validates with issubclass, logs and strips invalid poolclass from kwargs, and proceeds to create the async engine with the sanitized/validated configuration.

Changes

Cohort / File(s)	Summary
Database engine poolclass validation src/backend/base/langflow/services/database/service.py	Adjusts poolclass retrieval to sa.pool, validates via issubclass, logs and removes invalid poolclass from kwargs, and uses the validated/sanitized value when calling create_async_engine. No public API signature changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant DatabaseService as DatabaseService._create_engine
  participant SA as sqlalchemy
  participant Engine as create_async_engine

  Caller->>DatabaseService: _create_engine(**kwargs)
  activate DatabaseService

  DatabaseService->>SA: Lookup poolclass in sa.pool
  alt poolclass provided
    alt poolclass is subclass of sa.pool.Pool
      note right of DatabaseService: Valid poolclass retained
    else poolclass invalid
      DatabaseService->>DatabaseService: Log error and remove poolclass from kwargs
      note right of DatabaseService: Invalid poolclass stripped
    end
  else no poolclass provided
    note right of DatabaseService: Proceed without poolclass
  end

  DatabaseService->>Engine: create_async_engine(**sanitized_kwargs)
  Engine-->>DatabaseService: engine instance
  DatabaseService-->>Caller: engine instance
  deactivate DatabaseService

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 error, 2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Coverage For New Implementations	❌ Error	The PR adjusts the database service pool class validation but does not add or modify any backend tests (no files following the test_*.py convention appear in the diff), so there is no regression or unit coverage confirming the fix for pool class handling.	Please add regression tests that reproduce the NullPool failure scenario and confirm the new issubclass-based validation works, ideally in a backend test_*.py file covering the service’s _create_engine logic.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Test Quality And Coverage	⚠️ Warning	LangFlow PR 10232 introduces modifications to the SQL engine creation logic but adds no accompanying tests, leaving new behavior unverified and lowering confidence that pool class validation works across scenarios. As there are no tests exercising the revised issubclass-based path or ensuring error logging and kwargs sanitization, the update fails to meet the project’s testing expectations for backend changes. Without targeted regression coverage, this adjustment could reintroduce similar issues undetected.	Please add backend pytest coverage that simulates LANGFLOW_DB_CONNECTION_SETTINGS with a NullPool and other representative pool class cases, asserts that the engine initialization proceeds or fails as intended, and verifies that invalid pool class entries are removed from kwargs with appropriate logging.
Test File Naming And Structure	❓ Inconclusive	No new or modified test files are included in this pull request, so none of the specified naming, structural, or coverage expectations can be evaluated; therefore the status of this check is indeterminate.	Please add or reference test updates that align with the required naming and structural conventions, then rerun this check to confirm compliance.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Excessive Mock Usage Warning	✅ Passed	No test files were modified in this pull request, and a search of the repository’s test suite did not reveal any new or existing tests tied to the updated pool creation logic that rely on heavy mocking; consequently, there is no evidence of excessive mock usage introduced or exposed by these changes.
Title check	✅ Passed	The PR title accurately reflects the main technical change: replacing isinstance() with issubclass() for pool class validation, which directly addresses the core issue of pool initialization without instantiation.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/backend/base/langflow/services/database/service.py (1)

130-136: LGTM! Fix correctly addresses the NullPool instantiation issue.

The changes resolve the core problem by:

• Retrieving pool classes from sa.pool module (line 130) instead of the root sa namespace
• Using issubclass() (line 131) to validate the class hierarchy without instantiation, which prevents the "missing 'creator' argument" error for NullPool and similar pool classes
• Using safer kwargs.pop() (line 136) instead of del to avoid potential KeyError

Optional: Add defensive error handling around issubclass().

While unlikely, if pool_class is not actually a class, issubclass() raises TypeError. Consider wrapping the check for robustness:

 poolclass_key = kwargs.get("poolclass")
 if poolclass_key is not None:
     pool_class = getattr(sa.pool, poolclass_key, None)
-    if pool_class and issubclass(pool_class, sa.pool.Pool):
-        logger.debug(f"Using poolclass: {poolclass_key}.")
-        kwargs["poolclass"] = pool_class
-    else:
-        logger.error(f"Invalid poolclass '{poolclass_key}' specified. Using default pool class.")
-        kwargs.pop("poolclass", None)
+    try:
+        if pool_class and issubclass(pool_class, sa.pool.Pool):
+            logger.debug(f"Using poolclass: {poolclass_key}.")
+            kwargs["poolclass"] = pool_class
+        else:
+            logger.error(f"Invalid poolclass '{poolclass_key}' specified. Using default pool class.")
+            kwargs.pop("poolclass", None)
+    except TypeError:
+        logger.error(f"Invalid poolclass '{poolclass_key}' specified (not a class). Using default pool class.")
+        kwargs.pop("poolclass", None)

Verify the fix resolves the NullPool configuration issue.

Please confirm that setting LANGFLOW_DB_CONNECTION_SETTINGS={"poolclass": "NullPool"} no longer raises the "missing 'creator' argument" error and that the engine initializes successfully with NullPool.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f24a064 and 83c5d1c.

📒 Files selected for processing (1)

• src/backend/base/langflow/services/database/service.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

{src/backend/**/*.py,tests/**/*.py,Makefile}

📄 CodeRabbit inference engine (.cursor/rules/backend_development.mdc)

{src/backend/**/*.py,tests/**/*.py,Makefile}: Run make format_backend to format Python code before linting or committing changes
Run make lint to perform linting checks on backend Python code

Files:

• src/backend/base/langflow/services/database/service.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Optimize new Python code in this PR
• GitHub Check: Update Starter Projects

[github-actions]

Frontend Unit Test Coverage Report

Coverage Summary

Lines	Statements	Branches	Functions
	14.68% (3983/27130)	7.57% (1560/20599)	8.94% (535/5982)

Unit Test Results

Tests	Skipped	Failures	Errors	Time
1630	0 💤	0 ❌	0 🔥	18.794s ⏱️

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.61%. Comparing base (318805c) to head (c964d50).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...backend/base/langflow/services/database/service.py	0.00%	3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (38.92%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10232      +/-   ##
==========================================
- Coverage   31.62%   31.61%   -0.02%     
==========================================
  Files        1348     1348              
  Lines       61098    61099       +1     
  Branches     9129     9129              
==========================================
- Hits        19322    19314       -8     
- Misses      40863    40873      +10     
+ Partials      913      912       -1     

Flag	Coverage Δ
backend	51.77% <0.00%> (-0.07%)	⬇️
frontend	13.59% <ø> (ø)
lfx	38.92% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...backend/base/langflow/services/database/service.py	59.56% <0.00%> (-3.02%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Cristhianzl]

lgtm