fix: prevent UI from getting stuck when switching to cURL mode after parse errors

[andifilhohub]

Previously, when switching to cURL mode, a failure during parse_curl would break the internal build_config update, leaving the interface visually stuck in URL mode. This patch ensures curl_input is always displayed when mode="cURL" and cURL parsing errors are safely logged without interrupting the UI state update.

reported here: #10501

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for cURL input parsing to prevent application crashes when invalid input is encountered, while preserving existing configuration settings.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The change adds error handling to the update_build_config function in api_request.py. When in cURL mode with curl_input present, parsing is now wrapped in a try/except block that catches ValueError exceptions, logs a failure message, and continues without raising the error, preserving the existing build_config state.

Changes

Cohort / File(s)	Summary
Error handling for cURL parsing src/lfx/src/lfx/components/data/api_request.py	Added try/except block around parse_curl call in update_build_config to catch ValueError, log failure, and continue without re-raising

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Focused change in a single function with straightforward error handling logic
• Verify that swallowing ValueError is the correct behavior and doesn't mask legitimate parsing issues
• Confirm the logged failure message provides sufficient debugging information
• Check that preserving the previous build_config state is the intended behavior when parsing fails

Possibly related PRs

• fix: api request component curl mode error #8353: Also modifies update_build_config in api_request.py to change cURL input parsing behavior—adds parse_curl invocation and conditional parsing logic when curl_input changes, whereas this PR wraps existing parse_curl in error handling.

Suggested labels

bug, size:XS, lgtm

Suggested reviewers

• Cristhianzl
• Yukiyukiyeah

Pre-merge checks and finishing touches

❌ Failed checks (1 error, 1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Test Coverage For New Implementations	❌ Error	PR implements bug fix for parse_curl error handling but lacks corresponding test coverage.	Add unit tests verifying update_build_config handles ValueError exceptions gracefully and preserves build_config state when parsing fails.
Test File Naming And Structure	⚠️ Warning	The PR modifies error handling in api_request.py with a try/except block but includes no test files to verify the new error handling behavior, logging, or build_config state preservation.	Add test_api_request.py following pytest patterns with tests for: successful curl parsing, ValueError exception handling, build_config state preservation on errors, and curl_input display after parse failures.
Test Quality And Coverage	❓ Inconclusive	Repository not accessible in sandbox environment preventing evaluation of test coverage for bug fix implementation.	Provide access to modified api_request.py file, test files for api_request module, and confirmation of test coverage for valid and invalid cURL input scenarios.
Excessive Mock Usage Warning	❓ Inconclusive	Cannot assess excessive mock usage without access to test files covering the modified api_request.py module.	Provide test files for api_request.py to analyze mock usage patterns and verify if mocks are used appropriately for external dependencies only.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: preventing UI freezing when switching to cURL mode after parse errors, which matches the changeset's core objective.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/lfx/src/lfx/components/data/api_request.py (1)

469-470: Consider adding error handling for consistency.

This code path also calls parse_curl but lacks the error handling added at lines 476-479. If a user directly edits the curl_input field with invalid syntax, the same UI stuck issue could occur here.

Apply this diff to add consistent error handling:

     if field_name != "mode":
         if field_name == "curl_input" and self.mode == "cURL" and self.curl_input:
-            return self.parse_curl(self.curl_input, build_config)
+            try:
+                return self.parse_curl(self.curl_input, build_config)
+            except ValueError as e:
+                self.log(f"Failed to parse cURL input: {e}")
+                return build_config
         return build_config

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed4385b and a978919.

📒 Files selected for processing (1)

• src/lfx/src/lfx/components/data/api_request.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/lfx/src/lfx/components/data/api_request.py (1)

src/lfx/src/lfx/custom/custom_component/component.py (1)

• log (1480-1497)

🪛 GitHub Actions: Ruff Style Check

src/lfx/src/lfx/components/data/api_request.py

[error] 476-476: Ruff: Trailing whitespace (W291) detected. Remove trailing spaces. Command: uv run --only-dev ruff check --output-format=github .

🪛 GitHub Check: Ruff Style Check (3.13)

src/lfx/src/lfx/components/data/api_request.py

[failure] 476-476: Ruff (W291)
src/lfx/src/lfx/components/data/api_request.py:476:21: W291 Trailing whitespace

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Update Component Index
• GitHub Check: Update Starter Projects

🔇 Additional comments (1)

src/lfx/src/lfx/components/data/api_request.py (1)

476-479: Error handling successfully prevents UI from getting stuck.

The try/except block appropriately catches ValueError (which parse_curl raises on line 276) and logs the error without interrupting the UI state update. This ensures the cURL input field remains visible even when parsing fails, directly addressing the PR objective.

[erichare]

LGTM, great work @andifilhohub