feat: No size constraints for sticky notes (#10393)#10394
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe PR removes maximum width and height size constraints from the NoteNode component's resize functionality. The corresponding maximum dimension constants are deleted from the constants file, while minimum dimension constraints remain in place. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 error, 3 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When documenting larger flows with sticky notes and grouping larger sections of the flow, the size constraints are very limiting. No more than three elements can effectively fit on a sticky note. By removing the size constraint, we enable users to more effectively create visual groups in a flow.
7d6a12a to
9b7bc7c
Compare
|
@ochosi posting this in the related PR's: initial thoughts on how we'll be solving:
|
|
@seanjameshale-prog Thanks for the feedback! I love the idea of a dedicated "Section" component for grouping, and that should definitely be explored. However, for this specific PR, the goal is slightly different. I'm trying to improve documentation context rather than structural grouping. Often, you need a sticky note to "visually touch" multiple interacting components to explain a complex flow. Also, as opposed to what I imagine a section to be, I frequently use prose to provide more context to less technical reviewers. Small stickies make this difficult. I considered a separate component for what I wanted to achieve, but it would essentially be a fork of |
|
I agree with @ochosi. By allowing documentation to, in a way, span more than one component we can more easily document intentions rather than instructions. |
…low-ai#10394) When documenting larger flows with sticky notes and grouping larger sections of the flow, the size constraints are very limiting. No more than three elements can effectively fit on a sticky note. By removing the size constraint, we enable users to more effectively create visual groups in a flow. Co-authored-by: Deon Sanchez <69873175+deon-sanchez@users.noreply.github.com>
When documenting larger flows with sticky notes and grouping larger sections of the flow, the size constraints are very limiting. No more than three elements can effectively fit on a sticky note.
By removing the size constraint, we enable users to more effectively create visual groups in a flow.
See #10393 for the full context of this change.
Note: I'm not aware of any negative effects of this change, so I wasn't sure what to test for.
Before:

After:

Summary by CodeRabbit