fix: add max note node width#8648
Conversation
WalkthroughThe changes update CSS classes and constants to adjust the appearance and behavior of note-related nodes in the frontend. This includes modifying padding, font size, transition effects, width constraints, and maximum allowed dimensions for resizable note nodes. No changes were made to exported or public entity declarations except for updating a constant value. Changes
Suggested labels
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (7)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
ogabrielluiz
left a comment
There was a problem hiding this comment.
hey @lucaseduoli
Could you provide a better PR title? What does adding the NOTE_NODE_MAX_WIDTH do?
Added max note width
Added max note width
This pull request includes updates to the frontend codebase, focusing on improving the behavior and styling of custom nodes, particularly the
NoteNodecomponent. The changes include adjustments to size constraints, styling refinements, and enhancements to the user experience when resizing nodes.Updates to
NoteNodeComponent:NOTE_NODE_MAX_HEIGHTand updatedNOTE_NODE_MAX_WIDTHto allow larger dimensions forNoteNoderesizing. This improves flexibility for users managing larger content. (src/frontend/src/CustomNodes/NoteNode/index.tsx, [1];src/frontend/src/constants/constants.ts, [2]maxWidthandmaxHeightinto theNodeResizercomponent to enforce the new size constraints. (src/frontend/src/CustomNodes/NoteNode/index.tsx, src/frontend/src/CustomNodes/NoteNode/index.tsxR116-R117)Styling Improvements:
transition-allclass in multiple places and refined transition effects for smoother resizing and appearance changes. (src/frontend/src/CustomNodes/NoteNode/index.tsx, [1] [2]min-w-fullto ensure consistent minimum width styling forNoteNode. (src/frontend/src/CustomNodes/NoteNode/index.tsx, src/frontend/src/CustomNodes/NoteNode/index.tsxR173)Other Adjustments:
NodeDescriptionstyling to include a new text size (!text-mmd) for sticky notes, enhancing readability. (src/frontend/src/CustomNodes/GenericNode/components/NodeDescription/index.tsx, src/frontend/src/CustomNodes/GenericNode/components/NodeDescription/index.tsxL158-R158)width: fit-contentfrom.react-flow__nodein CSS to simplify layout handling. (src/frontend/src/App.css, src/frontend/src/App.cssL22)Summary by CodeRabbit
Style
New Features
Bug Fixes