fix: refactor mcp and freeze tests to be less prone to flaky results

[lucaseduoli]

This pull request adds a retry mechanism to ensure that a dropdown becomes enabled in the mcp-server.spec.ts test file. The change introduces logic to repeatedly check the dropdown's state and refresh the page if needed, improving test reliability.

Enhancements to test reliability:

• src/frontend/tests/extended/features/mcp-server.spec.ts: Added a loop with retry logic to check if the dropdown identified by [data-testid="dropdown_str_tool"] becomes enabled. If it is not enabled after multiple attempts, an error is thrown. This ensures the test does not proceed until the dropdown is interactable.

Summary by CodeRabbit

• Tests
  • Improved reliability of dropdown enablement checks in the SSE tab by adding a retry mechanism with refresh attempts and delays during automated testing.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A retry mechanism was added to a frontend test for the SSE tab. The new logic repeatedly checks if a dropdown becomes enabled after clicking a refresh button, with delays and a maximum retry count. If unsuccessful after all attempts, the test throws an error. No exported or public entity declarations were changed.

Changes

File(s)	Change Summary
src/frontend/tests/extended/features/mcp-server.spec.ts	Added retry loop to wait for dropdown enablement in SSE tab, with refresh button interaction.

Suggested labels

bug, size:S, lgtm

Suggested reviewers

• mfortman11
• Cristhianzl

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Cristhianzl]

lgtm

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/frontend/tests/extended/features/mcp-server.spec.ts (1)

107-110: Unnecessary fixed delay before retry loop

await page.waitForTimeout(1000); introduces a blind 1-second pause that is not tied to any page condition and is easily forgotten later. The subsequent while loop already contains a controlled 3-second delay when needed. Consider removing this sleep to keep the test fast.

-    await page.waitForTimeout(1000);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fd8be5 and 0ab55a4.

📒 Files selected for processing (1)

• src/frontend/tests/extended/features/mcp-server.spec.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: autofix

🔇 Additional comments (1)

src/frontend/tests/extended/features/mcp-server.spec.ts (1)

107-128: Duplicate retry boilerplate – extract to helper to reduce flakiness surface

The file now contains three almost-identical retry loops. Consolidating them into a small utility (e.g., retryUntilEnabled(page, testId, refreshButtonTestId)) would:

• Eliminate copy-paste divergence (see timeout mismatch above).
• Centralise max-attempt logic and logging.
• Simplify future tweaks (e.g., jitter, exponential backoff).

Not blocking for this PR, but worth scheduling.

[ suggest_optional_refactor ]

[coderabbitai]

🛠️ Refactor suggestion

Retry logic inconsistent with the first loop – first iteration wastes up to 30 s

In the earlier block (lines 38-55) you optimistically click the refresh button first, then wait with a 10 s timeout.
Here, the first iteration waits 30 s before the first refresh click, significantly slowing the test in the common “dropdown never enables” scenario.

Recommend mirroring the earlier pattern:

-    while (attempts < maxAttempts && !dropdownEnabled) {
-      await page.waitForTimeout(3000);
+    while (attempts < maxAttempts && !dropdownEnabled) {
+      // Trigger a refresh **before** waiting, just like the first loop
+      await page.getByTestId("refresh-button-sse_url").click();
+      await page.waitForTimeout(3000);
@@
-          {
-            timeout: 30000,
-            state: "visible",
-          },
+          { timeout: 10000, state: "visible" },
@@
-        attempts++;
-        console.log(`Retry attempt ${attempts} for second refresh button`);
-        await page.getByTestId("refresh-button-sse_url").click();
+        attempts++;
+        console.log(`Retry attempt ${attempts} for refresh-button-sse_url`);

Benefits
• Shaves up to ~20 s per failing attempt.
• Keeps both retry blocks homogenous, easing future refactors.
• Shorter timeout (10 s) matches the earlier loop; large 30 s waits rarely add value in UI polling.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	while (attempts < maxAttempts && !dropdownEnabled) {
	await page.waitForTimeout(3000);
	try {
	await page.waitForSelector(
	'[data-testid="dropdown_str_tool"]:not([disabled])',
	{
	timeout: 30000,
	state: "visible",
	},
	);
	dropdownEnabled = true;
	} catch (error) {
	attempts++;
	console.log(`Retry attempt ${attempts} for second refresh button`);
	await page.getByTestId("refresh-button-sse_url").click();
	}
	}
	while (attempts < maxAttempts && !dropdownEnabled) {
	// Trigger a refresh **before** waiting, just like the first loop
	await page.getByTestId("refresh-button-sse_url").click();
	await page.waitForTimeout(3000);
	try {
	await page.waitForSelector(
	'[data-testid="dropdown_str_tool"]:not([disabled])',
	{ timeout: 10000, state: "visible" },
	);
	dropdownEnabled = true;
	} catch (error) {
	attempts++;
	console.log(`Retry attempt ${attempts} for refresh-button-sse_url`);
	}
	}

🤖 Prompt for AI Agents

In src/frontend/tests/extended/features/mcp-server.spec.ts around lines 111 to
128, the retry loop waits 30 seconds before the first refresh button click,
causing unnecessary delay. To fix this, refactor the loop to click the refresh
button first, then wait for the dropdown selector with a shorter 10-second
timeout, matching the earlier loop's pattern. This change will reduce wait times
on failures and keep retry logic consistent across the test.