Skip to content

Update libsqlite3-sys to 0.34.0#3888

Closed
partylikeits1983 wants to merge 1 commit intolaunchbadge:mainfrom
partylikeits1983:main
Closed

Update libsqlite3-sys to 0.34.0#3888
partylikeits1983 wants to merge 1 commit intolaunchbadge:mainfrom
partylikeits1983:main

Conversation

@partylikeits1983
Copy link
Copy Markdown

Does your PR solve an issue?

Yes. This PR resolves a version conflict between sqlx and other dependencies (like rusqlite) caused by incompatible versions of the libsqlite3-sys crate, which links the native SQLite library. Cargo requires only one version of such native-linking crates in the dependency graph.

By updating sqlx to use a compatible libsqlite3-sys version, this conflict is eliminated, allowing both libraries to coexist in the project.

Is this a breaking change?

No. This change only updates internal dependencies to align native library versions without changing any public APIs or behavior.

@cvengler
Copy link
Copy Markdown

I'm having the same issue. This seems like a good fix to me, although the red CI warnings are a bit unsatisfying.

@partylikeits1983
Copy link
Copy Markdown
Author

I'm having the same issue. This seems like a good fix to me, although the red CI warnings are a bit unsatisfying.

Yeah, this PR is just to demonstrate that this is a fix for me. Obviously other parts of the code base need to be changed before this could be merged.

@abonander
Copy link
Copy Markdown
Collaborator

@partylikeits1983 it looks like you ran cargo update which changed a bunch of stuff in the Cargo.lock, can you please revert that change?

@partylikeits1983
Copy link
Copy Markdown
Author

Thank you for the update! This PR was honestly just to demonstrate what needed to be updated! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants