Update libsqlite3-sys to 0.34.0#3888
Closed
partylikeits1983 wants to merge 1 commit intolaunchbadge:mainfrom
Closed
Update libsqlite3-sys to 0.34.0#3888partylikeits1983 wants to merge 1 commit intolaunchbadge:mainfrom
0.34.0#3888partylikeits1983 wants to merge 1 commit intolaunchbadge:mainfrom
Conversation
|
I'm having the same issue. This seems like a good fix to me, although the red CI warnings are a bit unsatisfying. |
Author
Yeah, this PR is just to demonstrate that this is a fix for me. Obviously other parts of the code base need to be changed before this could be merged. |
Collaborator
|
@partylikeits1983 it looks like you ran |
3 tasks
Author
|
Thank you for the update! This PR was honestly just to demonstrate what needed to be updated! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Yes. This PR resolves a version conflict between
sqlxand other dependencies (likerusqlite) caused by incompatible versions of thelibsqlite3-syscrate, which links the native SQLite library. Cargo requires only one version of such native-linking crates in the dependency graph.By updating
sqlxto use a compatiblelibsqlite3-sysversion, this conflict is eliminated, allowing both libraries to coexist in the project.Is this a breaking change?
No. This change only updates internal dependencies to align native library versions without changing any public APIs or behavior.