Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Fix & lint type defs #62

Merged
dlau merged 3 commits into from
May 16, 2017
Merged

Fix & lint type defs #62

dlau merged 3 commits into from
May 16, 2017

Conversation

@natebrennand
Copy link

@natebrennand natebrennand commented May 16, 2017

The double block comment seems to have broken ts-node's parser. Was receiving these errors:

ERROR in [at-loader] ./node_modules/ldclient-node/index.d.ts:300:33
    TS2304: Cannot find name 'LDFlag'.

ERROR in [at-loader] ./node_modules/ldclient-node/index.d.ts:312:48
    TS2304: Cannot find name 'bool'.

ERROR in [at-loader] ./node_modules/ldclient-node/index.d.ts:353:20
    TS2304: Cannot find name 'variation'.

I'm not certain that this fixes everything but it does work with the our code's usage of the client.

CC @dlau

@dlau
Copy link
Contributor

dlau commented May 16, 2017

lgtm 👍

@dlau dlau merged commit 69025dc into launchdarkly:master May 16, 2017
@natebrennand natebrennand deleted the fix-type-defs branch May 16, 2017 21:40
@dlau
Copy link
Contributor

dlau commented May 16, 2017

in npm under 3.0.12

@natebrennand natebrennand mentioned this pull request May 16, 2017
Merged
eli-darkly added a commit that referenced this pull request May 10, 2018
@eli-darkly
Merge pull request #62 from launchdarkly/eb/ch12906/summary-events
599b481 
implement summary events
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natebrennand @dlau