This repository was archived by the owner on May 30, 2024. It is now read-only.
type def fixes #63
Merged
type def fixes #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebrennand
commented
May 16, 2017
| * Will be called after the upsert operation is complete. | ||
| */ | ||
| upsert: (key: string, flag: LDFlag, callback?: () => void) => void; | ||
| upsert: (key: string, flag: LDFlagValue, callback?: () => void) => void; |
Author
There was a problem hiding this comment.
There was no definition for LDFlag, but there was for LDFlagValue.
natebrennand
commented
May 16, 2017
| variation: (key: string, user: LDUser, defaultValue: LDFlagValue, callback?: (err: any, res: LDFlagValue) => void) => void; | ||
|
|
||
| toggle: typeof variation; | ||
| toggle: (key: string, user: LDUser, defaultValue: LDFlagValue, callback?: (err: any, res: LDFlagValue) => void) => void; |
Author
There was a problem hiding this comment.
I don't know of a terse way to replicate a function type definition. If toggle is deprecated, maybe the solution is to just remove it from the type definitions altogether?
Contributor
There was a problem hiding this comment.
I think we should keep it for legacy compatibility until we remove it.
Contributor
|
Thanks for this. 👍 |
Contributor
|
published to npm |
Closed
eli-darkly
added a commit
that referenced
this pull request
May 10, 2018
…ack-util [ch15352] Fix promise/callback utility…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I didn't quite do my due diligence before opening #62. Found 3 more small things.