robot_name should not define the namespace #344
Merged
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on(robot_name) to LaunchConfiguration(namespace)
mhubii
requested changes
Dec 20, 2025
Collaborator
mhubii
left a comment
mhubii
left a comment
There was a problem hiding this comment.
thanks for the PR! Overall looks good now, left you some comments that need to be addressed
mhubii
requested changes
Dec 25, 2025
mhubii
approved these changes
Dec 31, 2025
Collaborator
mhubii
left a comment
mhubii
left a comment
There was a problem hiding this comment.
looks good now, will merge in the new year
Collaborator
|
/backport |
|
Backport branch created but failed to create PR. (see action log for full response) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time I think it should work better :D