robot_name should not define the namespace #343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 122a16a)
(cherry picked from commit 65e0933)
(cherry picked from commit 35dd8cc)
(cherry picked from commit 0140ac1)
Backport 308 to jazzy
(cherry picked from commit 2c388ef)
(cherry picked from commit 01e60f6)
Backport 311 to jazzy
(cherry picked from commit 521be77)
(cherry picked from commit 038703b)
(cherry picked from commit 006ad0c)
Backport 315 to jazzy
(cherry picked from commit e1c10c3)
(cherry picked from commit 941fb5b)
(cherry picked from commit b3a290d)
(cherry picked from commit fb280dc)
Backport 322 to jazzy
(cherry picked from commit cb87f75)
(cherry picked from commit f862d6b)
(cherry picked from commit 800138d)
(cherry picked from commit 0e5f7be)
(cherry picked from commit c938783)
(cherry picked from commit 9fe6149)
(cherry picked from commit d1f7887)
(cherry picked from commit dfe3915)
) (cherry picked from commit d33f9d4)
(cherry picked from commit e5d3fd3)
Backport 324 to jazzy
(cherry picked from commit f49490d)
(cherry picked from commit c6ff2bc)
Backport 331 to jazzy
(cherry picked from commit 47d8490)
(cherry picked from commit fb087a6)
Backport 334 to jazzy
(cherry picked from commit a4e2c59)
(cherry picked from commit 3c789a6)
Backport 339 to jazzy
…on(robot_name) to LaunchConfiguration(namespace)
Collaborator
|
Thanks for the PR! Could you try to checkout the rolling branch on your fork first and to apply changes there :). It appears you applied changes to your jazzy branch. |
Contributor
Author
|
@mhubii okay just to clarify, I have the changes on my forks' rolling branch now, but I can't edit this PR to point at that, so should I create a new PR where the base is jazzy and compare with rolling? |
Collaborator
|
Yes so this PR would simply be closed and replaced by a new one. The problem with this PR is that for some reason it changes 115 files, not sure why, likely because of mismatching branches. |
Contributor
Author
|
new PR #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #341. Not sure what the description should be, so i left it blank for now. Maybe just "Namespace for robot." ?
Thanks!