-
Notifications
You must be signed in to change notification settings - Fork 173
Closed
Description
@certik Builtin % in LPython doesn't work on arrays by default because it is implemented as a function and not a binop. So the question is which approach to follow,
- To make
_modfunction defined inlpython_builtin.pyvectorised; - Define
Modasbinopand then usebuilder->CreateSRemin LLVM backend. Note that not all backends might support modulus operation on types other than integers. - Define
modand then make it vectorisable.
I think 3rd approach is a good one and complies with Python and NumPy standards. What do you say @certik?
Originally posted by @czgdp1807 in #1002 (comment)
Metadata
Metadata
Assignees
Labels
No labels