Sinh & cosh numpy_intrinsic functions implemented #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhav2310
changed the title
Contributor
Author
|
@czgdp1807 could you please help me with this error? |
czgdp1807
force-pushed
the
sinh_&_cosh_functions
branch
from
d671c65 to
6e3f27b
Compare
czgdp1807
reviewed
Aug 22, 2022
integration_tests/elemental_05.py
Outdated
| for j in range(size2): | ||
| for k in range(size3): | ||
| for l in range(size4): | ||
| assert abs( ((sinh(array[i, j, k, l])%3) +2)/2 - result[i, j, k, l]) <= eps |
Collaborator
There was a problem hiding this comment.
@certik Builtin % in LPython doesn't work on arrays by default because it is implemented as a function and not a binop. So the question is which approach to follow,
- To make
_modfunction defined inlpython_builtin.pyvectorised; - Define
Modasbinopand then usebuilder->CreateSRemin LLVM backend. Note that not all backends might support modulus operation on types other than integers. - Define
modand then make it vectorisable.
I think 3rd approach is a good one and complies with Python and NumPy standards. What do you say @certik?
Closed
czgdp1807
force-pushed
the
sinh_&_cosh_functions
branch
4 times, most recently
from
4132dc8 to
7757d59
Compare
certik
approved these changes
Aug 29, 2022
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think this is good, thanks!
Co-authored-by: Madhav2310 <madhav.mittal.mat19@itbhu.ac.in>
Co-authored-by: Madhav2310 <madhav.mittal.mat19@itbhu.ac.in>
Co-authored-by: Madhav2310 <madhav.mittal.mat19@itbhu.ac.in>
Co-authored-by: Madhav2310 <madhav.mittal.mat19@itbhu.ac.in>
czgdp1807
force-pushed
the
sinh_&_cosh_functions
branch
from
7757d59 to
54e5bd0
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.