Multi arch builds #114
Merged
Multi arch builds #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This depends on learningequality/python-for-android#2 and then updating the requirements to use it. |
Member
|
Have merged learningequality/python-for-android#2, so feel free to update the commit to |
rtibbles
reviewed
Apr 29, 2022
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
This all looks good to me, can merge when the commit is updated.
Instead of building an APK per architecture, make use of p4a's recent multi-arch support to build a single multi-architecture APK. By default, 32 and 64 bit ARM and x86 are built, but this can be changed through the `ARCHES` environment variable. This depends on multi-arch support for the p4a webview bootstrap, which is not upstream yet.
Contributor
Author
|
Rebased and ready for review again with the p4a commit updated. |
rtibbles
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #108 and #112. See the last commit for details. I chose to build for all of armeabi-v7a, arm64-v8a, x86, and x86_64, although I don't know if x86 32 bit is actually needed or not.