Enable fullscreen for videos #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
reviewed
May 19, 2022
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Not tested, but a naming tweak and a question.
| @@ -0,0 +1,87 @@ | |||
| package org.endlessos; | |||
Member
There was a problem hiding this comment.
Suggested change
| package org.endlessos; | |
| package org.learningequality; |
Could we rename the file as well?
src/main.py
Outdated
|
|
||
| PythonActivity = autoclass("org.kivy.android.PythonActivity") | ||
|
|
||
| FullScreen = autoclass("org.endlessos.FullScreen") |
Member
There was a problem hiding this comment.
Suggested change
| FullScreen = autoclass("org.endlessos.FullScreen") | |
| FullScreen = autoclass("org.learningequality.FullScreen") |
| } | ||
|
|
||
| // Configure the WebView to allow fullscreen based on: | ||
| // https://stackoverflow.com/questions/15768837/playing-html5-video-on-fullscreen-in-android-webview/56186877#56186877 |
Member
There was a problem hiding this comment.
This suggests that we need updates to the AndroidManifest.xml as well, or does the P4A generated manifest already include the appropriate keys?
Contributor
Author
There was a problem hiding this comment.
In my tests the fullscreen was working correctly with just this java class, I didn't need to do anything else to have the fullscreen working for videos.
danigm
force-pushed
the
add-fullscreen-support
branch
from
3189c09 to
8e34edf
Compare
rtibbles
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #86