Backport: Enable fullscreen for videos #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamalex
approved these changes
Aug 9, 2022
Member
jamalex
left a comment
jamalex
left a comment
There was a problem hiding this comment.
Looks good to me at first pass!
| PythonActivity = autoclass("org.kivy.android.PythonActivity") | ||
| FullScreen = autoclass("org.learningequality.FullScreen") | ||
| configureWebview = Runnable(FullScreen.configureWebview) | ||
| configureWebview(PythonActivity.mActivity) |
Member
There was a problem hiding this comment.
This provides a great example for adding custom Java and tweaking the webview behavior without having to hack the P4A bootstrap. 🎆
Member
Author
There was a problem hiding this comment.
Yes, much thanks to @danigm for creating such a clean intervention! May help us to avoid having to fork P4A if we can follow this pattern more closely.
jamalex
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #116
Requires this additional commit in PyEverywhere: learningequality/pyeverywhere@b247cc6