Skip to content

Conversation

@FidalMathew
Copy link
Contributor

@FidalMathew FidalMathew commented Jan 3, 2024

Summary

Description of the change(s) you made

When the new search page opens, the filter is not applied, to tackle this issue, we are using the 'languages' param which is then imported by the language filter.

Manual verification steps performed

  1. Import from other channels
  2. Select a language and search item and click Search
  3. The new page will have the selected language

Screenshots (if applicable)

Before:
#4089 (comment)

After:
CPT2401032206-1528x627

Does this introduce any tech-debt items?

At present, upon clicking 'back to browse,' the language selection is not retained. It resets to nothing. This decision was made due to the introduction of a new page where users can select multiple languages. Fetching the previously selected language(s) might lead to errors due to this change in the user flow.


Reviewer guidance

How can a reviewer test these changes?

  1. Import from other channels
  2. Select a language and search item and click Search
  3. The new page will have the selected language

References

Addresses #4089

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@FidalMathew
Copy link
Contributor Author

@vkWeb could you take a look?

@vkWeb vkWeb self-assigned this Jan 4, 2024
@vkWeb
Copy link
Member

vkWeb commented Jan 4, 2024

@FidalMathew Assigned myself to this PR, will look soon.

Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On selecting a language and removing it, I'm getting the below error:

image

It's happening because we are navigating user to the same URL twice.

Instead of using router.push, let's take a different approach here -- whenever languageFilter is changed in ChannelList, emit an event from there, you can do that in the computed property. Then we will catch that event on SearchOrBrowseWindow's ChannelList and assign a data property that will be sent as a query param to handleSearchTerm method.

@vkWeb
Copy link
Member

vkWeb commented Jan 5, 2024

@FidalMathew you nearly solved the issue, good job! its just that the error I mentioned above has popped up. Let's refactor 🚀

@FidalMathew
Copy link
Contributor Author

@vkWeb thank you! I'll work on it.

@vkWeb
Copy link
Member

vkWeb commented Jan 5, 2024

@FidalMathew I'm looking forward to it!

@FidalMathew
Copy link
Contributor Author

@vkWeb I have made the updated PR. Could you take a look at it?

Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug -- now, your changes are not allowing to set two languages together in import search.

I have requested changes.

Copy link
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FidalMathew I pushed one commit that changes some variable names, and did minor logic correction. Merging in. Thanks buddy, good work! :D

@vkWeb vkWeb merged commit 4dde334 into learningequality:hotfixes Jan 11, 2024
@FidalMathew
Copy link
Contributor Author

Thank you @vkWeb for guiding me through the issue! 😄

@pcenov
Copy link
Member

pcenov commented Mar 8, 2024

Thanks @FidalMathew - I've tested the issue at hotfixes and confirm that the language filter is displayed correctly now.

@akolson akolson mentioned this pull request Apr 17, 2024
@bjester bjester added this to the Studio: rebranding patch milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants