Skip to content

Set ComboBox MinWidth on Border, not on Popup itself#1349

Merged
pomianowski merged 1 commit intolepoco:mainfrom
chucker:fix/599-combo-box-update
Feb 17, 2025
Merged

Set ComboBox MinWidth on Border, not on Popup itself#1349
pomianowski merged 1 commit intolepoco:mainfrom
chucker:fix/599-combo-box-update

Conversation

@chucker
Copy link
Copy Markdown
Collaborator

@chucker chucker commented Feb 16, 2025

Fixes #599; credit to @jschroedl

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When adding an item to a combo box after initial layout, with the parent having a horizontal layout (e.g., a StackPanel Orientation="Horizontal"), no space is provided for the added item.

Issue Number: #599

What is the new behavior?

The new item now appears.

@chucker chucker requested a review from pomianowski as a code owner February 16, 2025 19:42
@github-actions github-actions Bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request release labels Feb 16, 2025
@pomianowski pomianowski merged commit a8917ca into lepoco:main Feb 17, 2025
pomianowski pushed a commit that referenced this pull request Feb 17, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

controls Changes to the appearance or logic of custom controls. PR Pull request release styles Topic is related to styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBox items don't update properly on ItemsSource binding source collection changes

3 participants