Add CheckBox check animation#1511
Closed
Nuklon wants to merge 2 commits intolepoco:mainfrom
Closed
Conversation
github-actions
Bot
added
controls
Collaborator
Author
|
Going to close this for now. This should only be animated when the state changes, not when the initial state is checked. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently the animation used by WinUI when a checkbox is being checked is missing.
This adds that
Wpf.Ui.Gallery_EMhJHl7yVJ.mp4
(Big example checkbox so you can see what's happening).
There's no animation when going from checked to indeterminate/checked to unchecked/indeterminate to unchecked, this is the same with WinUI.