Skip to content

feat(controls): Add CheckBox animation #1512

Merged
pomianowski merged 5 commits intolepoco:mainfrom
Nuklon:patch-24
Nov 7, 2025
Merged

feat(controls): Add CheckBox animation #1512
pomianowski merged 5 commits intolepoco:mainfrom
Nuklon:patch-24

Conversation

@Nuklon
Copy link
Copy Markdown
Collaborator

@Nuklon Nuklon commented Aug 13, 2025

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Replacement of #1511. The animation I've added is a little different from WinUI, which slides in from left to right. This is quite difficult to recreate in WPF. My initial idea to animate based on CheckBoxIconSize doesn't work reliably given the actual size is calculated based on the underlying glyph / TextBlock, and is sometimes larger. The new animation is now just a fade in based on opacity.

Wpf.Ui.Gallery_EMhJHl7yVJ.mp4

@Nuklon Nuklon requested a review from pomianowski as a code owner August 13, 2025 14:23
@github-actions github-actions Bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request release labels Aug 13, 2025
@Nuklon
Copy link
Copy Markdown
Collaborator Author

Nuklon commented Aug 13, 2025

Thinking about it a little more, we can still do the idea of #1511, but now with the right properties to take the logical width into account.

@pomianowski pomianowski changed the title Add CheckBox animation feat(controls): Add CheckBox animation Nov 7, 2025
@pomianowski pomianowski merged commit 81c822c into lepoco:main Nov 7, 2025
1 check passed
@jschroedl
Copy link
Copy Markdown

@Nuklon I see that the CheckBoxAnimationFactorToValueConverter added (line 37) is not being used by the XAML. Is that a remnant or am I missing something?

<converters:AnimationFactorToValueConverter x:Key="CheckBoxAnimationFactorToValueConverter" />

Thanks a bunch for adding the animation BTW.

@Nuklon
Copy link
Copy Markdown
Collaborator Author

Nuklon commented Jan 15, 2026

@Nuklon I see that the CheckBoxAnimationFactorToValueConverter added (line 37) is not being used by the XAML. Is that a remnant or am I missing something?

<converters:AnimationFactorToValueConverter x:Key="CheckBoxAnimationFactorToValueConverter" />

Thanks a bunch for adding the animation BTW.

Yes, thanks, this is indeed unused, I've created a PR to drop this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controls Changes to the appearance or logic of custom controls. PR Pull request release styles Topic is related to styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants